Closing in favor of D31437

Probably incomplete, please let me know what I'm missing.

In D30667#699843, @markj wrote:

In D30667#699823, @swills wrote:

Changing file_name to const makes sense, but seems like a larger change, could we perhaps do that in a separate commit, just for clarity?

Ok. I still think we should not be malloc()ing file in this change though. Other than that and the inline comment, the change looks good to me.

Thanks for the review and writing the test! I've made the change to only call foward() if we're not calling follow().

In D30667#690869, @swills wrote:

In D30667#690850, @oshogbo wrote:

Hym its works for me.

# tail -f < pdfork.c 
        printf("%d\n", pid);
        fd2 = dup(fd);
...

What version of FreeBSD are you using there? For me, it doesn't work on 14-CURRENT without these changes.

In D30667#690850, @oshogbo wrote:

Hym its works for me.

# tail -f < pdfork.c 
        printf("%d\n", pid);
        fd2 = dup(fd);
...

In D30667#690843, @oshogbo wrote:

Can you provide some more context?

Looks OK to me. It is as you say a bit ugly, but I think it gets us where we want to be and is the best we can do until sub-packages are supported.

A command line argument to do this without the prompt (non-interactively) would be nice too.

I just kept the patch as before and it works as expected, i.e. nothing was changed. For the upstream question of the patches, I'm agreed and I think it should be chased during the next release update.

This sounds reasonable. Could you show the example usage (either in this diff or just add a pointer) just for reference? I'd especially like to compare the SED or REINPLACE_CMD usage to what you have with this in place. Thanks!

I think textproc/node-re2 got removed and this needs revision, but correct me if I'm wrong.

Sure, that's fine with me, go ahead.

Great, thanks!

Looks good, thanks!

In D28930#647904, @bapt wrote:

no the hashed db isn't faster, the hashed allow the ports tree to simply add its own terminal definition without the requirement of a script.
It allows base and ports to coexist better reusing common locations

Is there supposed to be a patch file here?

Why switch to non-hashed DB? Isn't hashed faster?