Fixed function parameter list indentation

Updated diff per markj@'s review and comments

Return positive values in lindebugfs.c so pseudofs vnops does not get confused.

Added manual page for lindebugfs

Minor modifications to lindebugfs.c

• Moved static inline functions out of debugfs.h and into lindebugfs.c.
• Removed unnecessary functions from debugfs.h.
• Generated diff with -U999999 flag.

@jfree if you generate another diff to update this review please include full context, e.g. git diff -U999999 or git show -U999999

Added parenthesis around return values per FreeBSD kernel style guide

• rebase
• add SYSUNINIT for deallocating the strings
• remove useless null check (kfree supports null)

Switch to sx lock

Use the linuxkpi allocator

It looks that sx lock suits our needs better than rw here.

add missing + 1 for strlen

format-patch w/o 9999 context: P538

Fix format (more %02d), move the new field to the end of the struct

I think GFP_KERNEL doesn't fail, see the definition.
GFP_ATOMIC can fail.

I am fine with this; iwlwifi only uses the output as informational in dumping and nowhere else and none of my other drivers I was checking do use it.

Fix style

Looks good.

Sorry for the delay. It looks good to me also.

I had to do this last year at some point for a local tree. Seems good.

LGTM.

Apologies; it appears I misread @emaste 's message. Yes, a general sysctl seems like a good idea. Apologies for any confusion.

In D30174#678213, @jakehfreebsd_gmail.com wrote:

Personally, I would support a sysctl for enabling these warning traces, as they could still be useful debugging tools in the right hands.

Personally, I would support a sysctl for enabling these warning traces, as they could still be useful debugging tools in the right hands.

I wonder if we should have a sysctl to enable warning stack dumps, e.g. from subr_witness.c

#if defined(DDB) || defined(KDB)
/*
 * When DDB or KDB is enabled and witness_trace is 1, it will cause the system
 * to print a stack trace:
 *      - a lock hierarchy violation occurs
 *      - locks are held when going to sleep.
 */
int     witness_trace = 1;
SYSCTL_INT(_debug_witness, OID_AUTO, trace, CTLFLAG_RWTUN, &witness_trace, 0, "");
#endif /* DDB || KDB */

Looks good!

Thanks, will comit this today.

Looks good!

In D28061#627019, @daniel.piecebypiece_yahoo.com wrote:

Done. It booted and I used it now for about 15 min. without any in the face issue.
Do you need any logs or sth. ?

> - ensure you have the latest src tree from https://cgit.freebsd.org/src/ in /usr/src

• apply the patch (e.g. curl -L https://github.com/DankBSD/base/commit/a3648bffd3e40d5bff6d1362c7c101e712ab1baa.patch | git am)
• the usual buildkernel installkernel
• get the gpu drivers from https://github.com/myfreeweb/drm-kmod/tree/5.4-lts-dank (git clone -b 5.4-lts-dank https://github.com/myfreeweb/drm-kmod)
• build (make -j30) and install ([sudo/doas/..] make install) them
• reboot :)

In D28061#627000, @daniel.piecebypiece_yahoo.com wrote:

How does the test plan look like ?

HI, I have a Navi10 card (5700XT) + AMD 5950X.
If that setup is suitable I would give it try ?

Looks okay to me as well. The two minor things may be ignored.

Looks good. You need someone to commit this?