Phew, big change to go through. I did not see anything that needs changing, so go ahead with the commit.
Thank you!
- Feed Queries
- All Stories
- Search
- Feed Search
- Transactions
- Transaction Logs
May 16 2023
May 11 2023
Alright, makes sense to me. Make a note of the decision in the commit message so that we have a track record of the decision.
It's documented in this review description, but a few words of explanation in the message itself should suffice.
May 10 2023
May 8 2023
Looks good to me. Definitely good to have, thanks!
Apr 25 2023
A couple of minor corrections and additions. It's good to have this documented in the FDP, thanks!
Apr 24 2023
@woodsb02: Are you working on a newer patch for dhcpcd-10 for inclusion into FreeBSD14?
Would really be great to have. If this needs any shepherding from core, I'll see what I can do.
Apr 19 2023
Looks good and would be good to have. Approved!
Mar 30 2023
Looks good to me.
Mar 29 2023
Excellent, more eyes catch more bugs.
Good work, approved also by me!
Good idea, giving this file an update.
Looking looking at the output, I only have two changes (one is purely cosmetical).
Mar 26 2023
Mar 24 2023
Looks good, approved!
Mar 12 2023
Mar 11 2023
Any updates on this?
Looks good to me, definitely useful to have.
Mar 10 2023
Looks good for the doc side of things.
Mar 9 2023
Sure, go ahead!
Excellent, nothing to complain about. Good work, ready to commit!
A few minor language fixes, the rest looks good to me.
Good to have these instructions, thanks for writing them down.
OK for the documentation side of things.
Thanks for your help with the release notes!
Feb 17 2023
Looks good. Don't forget the .Dd bump.
Feb 6 2023
Jan 20 2023
Found a few minor nits.
We should definitely recommend people to use GPT over MBR.
Jan 12 2023
OK for the man page part of the change.
Dec 30 2022
A few small corrections, the rest looks OK to me.
Good to have a TEX section in the porters handbook with this change!
Dec 29 2022
Dec 18 2022
Can someone commit this? Thanks!
Dec 15 2022
Dec 13 2022
Good catch, I'll take care of it.
Thank you!
Dec 10 2022
A few minor edits to the text: one missing word the others are suggestions only.
Looks good. Thank you for your continued work on all things NFS.
Dec 6 2022
OK from manpages for these latest changes. Thanks for your patience working on this patch!
Nov 15 2022
About the use of "you".
Nov 14 2022
Quick question: some of the if-statements here are wrapping the check into [], while others do not.
Do we have some kind of style-guide for shell scripts like this for consistency?
Nothing against the change per se, just wondering.
Nov 13 2022
Looks good, ready to commit!
Looks good now!
Looks good to me now. I'm approving this one and https://reviews.freebsd.org/D36769. Thanks!
Nov 12 2022
Looks good as a first introduction to vale. A few fixes and then you can commit it to the FDP primer.
I like these additions, thanks!
A few fixes provided in the comments.
Oct 29 2022
The term "Committer" was used way before SVN times.
Oct 28 2022
Found a line break after a sentence stop. You can run textproc/igor over your man page to find these.
Also, "mandoc -T lint" may also be helpful.
Very minor issue with the core-email in one place.
Thanks for working on this!
Oct 27 2022
Found a typo. You can fix it when committing. Thanks for this work!
Oct 23 2022
Oct 18 2022
Who's going to commit this?
Oct 13 2022
I would love to see this in the man page. Any updates?
Will someone commit this? It's been approved for a while...
Any updates on this one?
I like this initiative. It does make the page much better than before and with the update script, we'll keep it up-to-date.
I'd say we commit the base bits now and refine it in a follow-up commit (i.e. when the script is running with help from Sergio).
Any updates on this (from either side)?
Any updates on this one?
OK from manpages.
Oct 12 2022
Oct 11 2022
Looks good. Would be amazing if this would be updated automatically by a script of some kind.
Oct 8 2022
Oct 7 2022
OK from manpages.
Overcome by events, someone else removed the section by now.
Manpage looks good, we can do the filename markup in a followup commit.
The changes were already committed to the porters-handbook. You can close this review.
Thanks for submitting it anyway.
Manpage looks good. Thanks!
Confirm man page looks good.
OK from manpages.
OK for the man page change.
@ota_j.email.ne.jp: Can you update the rest so we can get this committed. Arigato!
Man page also looks good now.
Man page looks good, thanks!
Oct 6 2022
Oct 5 2022
Oct 1 2022
Any updates on this one? The suggested changes don't seem too difficult to me.
@ota_j.email.ne.jp are you interested in finishing this?
Looks good, can you commit this?
Can we get this committed? Seems mostly complete to me.
Any updates on this?
Explicitly approve the man page change.
@imp: Can you take care of the commit? I associate nvmecontrol mainly with you and you have a src bit to do the commit. Thank you!
Sep 30 2022
Approving the man page part.
Hope we can get it committed soon.
OK from manpages.
Would be good to see some progress on this.
Who's going to commit this? Seems like it's as complete as it can get.
Can we move this along or do we still have to discuss something about it?
Sep 29 2022
Both man pages look good now. Thank you!
Sep 28 2022
Thanks for the man page and the huge work implementing netlink!
Can hyou run "mandoc -Tlint" over it? There are at least a couple of instances where there must be a line break inserted after a sentence stop.
I started commenting some occurances, but rather than doing all of them, it's probably easier to go via the mandoc output.