Page MenuHomeFreeBSD
Feed Search

May 16 2023

bcr accepted D40080: porters-handbook/versions: Pet vale.

Phew, big change to go through. I did not see anything that needs changing, so go ahead with the commit.
Thank you!

May 16 2023, 6:28 PM

May 11 2023

bcr accepted D40063: vale/styles: Remove Weasel rule.

Alright, makes sense to me. Make a note of the decision in the commit message so that we have a track record of the decision.
It's documented in this review description, but a few words of explanation in the message itself should suffice.

May 11 2023, 1:49 PM

May 10 2023

bcr accepted D40029: vale: Add new rule to reduce usage of pronouns.
May 10 2023, 7:41 AM

May 8 2023

bcr accepted D39997: vt(4): document enable_altgr.

Looks good to me. Definitely good to have, thanks!

May 8 2023, 1:42 PM

Apr 25 2023

bcr added a comment to D39800: fdp-primer/writing-style: Refactor after adding new Vale rules.

A couple of minor corrections and additions. It's good to have this documented in the FDP, thanks!

Apr 25 2023, 2:07 PM
bcr added a comment to D39798: .vale.ini: Refactor.

Looks reasonable, approved!

Apr 25 2023, 2:02 PM

Apr 24 2023

bcr added a comment to D22012: Import dhcpcd(8) into FreeBSD base..

@woodsb02: Are you working on a newer patch for dhcpcd-10 for inclusion into FreeBSD14?
Would really be great to have. If this needs any shepherding from core, I'll see what I can do.

Apr 24 2023, 9:41 AM

Apr 19 2023

bcr accepted D39685: vale: Refactor Weasel rule.

Looks good and would be good to have. Approved!

Apr 19 2023, 9:15 AM

Mar 30 2023

bcr accepted D39340: committers-ports.dot: Bring file up to date..

Looks good to me.

Mar 30 2023, 11:23 AM

Mar 29 2023

bcr accepted D39309: committers-doc.dot: bring file up to date.

Excellent, more eyes catch more bugs.
Good work, approved also by me!

Mar 29 2023, 5:55 PM
bcr added a comment to D39309: committers-doc.dot: bring file up to date.

Good idea, giving this file an update.
Looking looking at the output, I only have two changes (one is purely cosmetical).

Mar 29 2023, 3:48 PM

Mar 26 2023

bcr accepted D39276: Core Team quarterly report.
Mar 26 2023, 2:34 PM

Mar 24 2023

bcr accepted D39252: Document __FreeBSD_version value 1400084 for arm64 ABI/KBI changes..

Looks good, approved!

Mar 24 2023, 10:43 AM

Mar 12 2023

bcr accepted D39016: 13.2 relnotes: additions/changes suggested by emaste.
Mar 12 2023, 9:19 AM

Mar 11 2023

bcr added a comment to D31612: Handbook/Introduction: Update the Developmen Model description.

Any updates on this?

Mar 11 2023, 2:12 PM
bcr accepted D31273: Strengthen warnings about ext4.

Looks good to me now.

Mar 11 2023, 2:09 PM
bcr accepted D37240: First batch of alt text to images in articles and books.

Looks good to me, definitely useful to have.

Mar 11 2023, 2:07 PM

Mar 10 2023

bcr accepted D39016: 13.2 relnotes: additions/changes suggested by emaste.

Looks good for the doc side of things.

Mar 10 2023, 3:32 PM

Mar 9 2023

bcr added a comment to D38998: 13.2 relnotes: updates on wifi and boot loader.

Sure, go ahead!

Mar 9 2023, 1:27 PM
bcr accepted D38919: freebsd-status-report-process: Add article.

Excellent, nothing to complain about. Good work, ready to commit!

Mar 9 2023, 1:20 PM
bcr added a comment to D38919: freebsd-status-report-process: Add article.

A few minor language fixes, the rest looks good to me.
Good to have these instructions, thanks for writing them down.

Mar 9 2023, 12:35 PM
bcr accepted D38998: 13.2 relnotes: updates on wifi and boot loader.

OK for the documentation side of things.
Thanks for your help with the release notes!

Mar 9 2023, 9:00 AM

Feb 17 2023

bcr accepted D38627: rc.conf.5: clarify source directories.

Looks good. Don't forget the .Dd bump.

Feb 17 2023, 12:43 PM

Feb 6 2023

bcr accepted D38399: tarfs: Fix typo in man page..

OK from manpages.

Feb 6 2023, 3:29 PM
bcr accepted D38373: libmd / md5: Add SHA-512/224..

OK from manpages.

Feb 6 2023, 2:06 PM

Jan 20 2023

bcr added a comment to D38137: handbook basics: add information about GPT partitions.

Found a few minor nits.
We should definitely recommend people to use GPT over MBR.

Jan 20 2023, 5:25 PM

Jan 12 2023

bcr accepted D37435: Allow netcat to be a tun tunnel broker.

OK for the man page part of the change.

Jan 12 2023, 3:07 PM

Dec 30 2022

bcr added a comment to D37745: Add USES=tex.

A few small corrections, the rest looks OK to me.
Good to have a TEX section in the porters handbook with this change!

Dec 30 2022, 8:54 AM

Dec 29 2022

bcr accepted D37749: Fix INSTALL_DATA.

Looks good, approved for commit!

Dec 29 2022, 7:01 PM

Dec 18 2022

bcr added a comment to D37203: xlocale(3): Link man pages.

Can someone commit this? Thanks!

Dec 18 2022, 12:18 PM
bcr added inline comments to D37722: Add new rc: machine_id to generate /etc/machine-id.
Dec 18 2022, 12:14 PM

Dec 15 2022

bcr accepted D37710: spkrtest.8: Add module info.

Looks good to me.

Dec 15 2022, 3:12 PM

Dec 13 2022

bcr closed D37686: rcorder(8): Fix the EXAMPLES section.
Dec 13 2022, 7:58 PM
bcr committed rG47972d6dc4cb: Fix rcorder example to match the keyword in the description (authored by jlduran).
Dec 13 2022, 7:57 PM
bcr accepted D37686: rcorder(8): Fix the EXAMPLES section.

Good catch, I'll take care of it.
Thank you!

Dec 13 2022, 7:40 PM

Dec 10 2022

bcr added a comment to D37616: Handbook WG - Part I - Introduction - bsdinstall.

A few minor edits to the text: one missing word the others are suggestions only.

Dec 10 2022, 5:20 PM
bcr accepted D37665: patch jail.8 man page to add info on allow.nfsd.

Looks good. Thank you for your continued work on all things NFS.

Dec 10 2022, 10:10 AM

Dec 6 2022

bcr accepted D27318: freebsd-version(1): present -v option, to print verbose output.

OK from manpages for these latest changes. Thanks for your patience working on this patch!

Dec 6 2022, 4:29 PM

Nov 15 2022

bcr added a comment to D37381: Vale introduction in FDP.

About the use of "you".

Nov 15 2022, 2:14 PM · doceng

Nov 14 2022

bcr accepted D37381: Vale introduction in FDP.

Looks good!

Nov 14 2022, 8:37 AM · doceng
bcr added a comment to D37383: service(8): add -s for showing status.

Quick question: some of the if-statements here are wrapping the check into [], while others do not.
Do we have some kind of style-guide for shell scripts like this for consistency?
Nothing against the change per se, just wondering.

Nov 14 2022, 8:22 AM · rc

Nov 13 2022

bcr accepted D37377: vim configuration for vale.

Looks good, ready to commit!

Nov 13 2022, 9:22 AM · doceng
bcr accepted D36769: Add documentation of pkg-{pre,post}-[de]install[.lua].

Looks good now!

Nov 13 2022, 9:19 AM
bcr accepted D36770: Copyedit zirias' pre*/post* update..

Looks good to me now. I'm approving this one and https://reviews.freebsd.org/D36769. Thanks!

Nov 13 2022, 9:19 AM

Nov 12 2022

bcr added a comment to D37362: vale integration with editors.

Looks good as a first introduction to vale. A few fixes and then you can commit it to the FDP primer.

Nov 12 2022, 6:20 PM
bcr added a comment to D36769: Add documentation of pkg-{pre,post}-[de]install[.lua].

I like these additions, thanks!
A few fixes provided in the comments.

Nov 12 2022, 2:28 PM

Oct 29 2022

bcr added a comment to D37207: Fixing the definition of the term "committer".

The term "Committer" was used way before SVN times.

Oct 29 2022, 4:47 PM · docs

Oct 28 2022

bcr added a comment to D32700: nvmecontrol: Implement Get/Set Feature for nvmecontrol.

Found a line break after a sentence stop. You can run textproc/igor over your man page to find these.
Also, "mandoc -T lint" may also be helpful.

Oct 28 2022, 6:46 AM
bcr added a comment to D29543: license: Create a license guideline document.

Very minor issue with the core-email in one place.
Thanks for working on this!

Oct 28 2022, 6:14 AM

Oct 27 2022

bcr added a comment to D37135: hier(7): remove text describing /usr/src layout.

Found a typo. You can fix it when committing. Thanks for this work!

Oct 27 2022, 7:00 AM

Oct 23 2022

bcr requested review of D37096: Add missing resolv.conf(5) options documentation .
Oct 23 2022, 10:23 AM

Oct 18 2022

bcr added a comment to D34012: sysctl: Add -F option to display sysctl format, refactor for a function to display info options for and added test cases.

Who's going to commit this?

Oct 18 2022, 8:30 AM

Oct 13 2022

bcr added a comment to D33233: sync.8: Document that the "sync dance" is not a thing.

I would love to see this in the man page. Any updates?

Oct 13 2022, 6:30 PM
bcr added a comment to D26552: Revert DTS for omap family for stable/12 and releng 12.2.

Will someone commit this? It's been approved for a while...

Oct 13 2022, 6:25 PM · ARM
bcr added a comment to D32979: ps(1): let J flag list all jailed processes.

Any updates on this one?

Oct 13 2022, 4:44 PM
bcr accepted D36972: books: Updating ports count statistics in dev-model.

I like this initiative. It does make the page much better than before and with the update script, we'll keep it up-to-date.
I'd say we commit the base bits now and refine it in a follow-up commit (i.e. when the script is running with help from Sergio).

Oct 13 2022, 4:42 PM · docs
bcr added a comment to D18832: NTB Perf: Tool to measure performance of NTB hw drivers.

Any updates on this (from either side)?

Oct 13 2022, 4:37 PM
bcr added a comment to D32985: New manual page for vmrun.sh.

Any updates on this one?

Oct 13 2022, 4:34 PM · bhyve
bcr accepted D35401: pmcannotate: Add a '-m' mode option to control per-line annotations..

OK from manpages.

Oct 13 2022, 4:32 PM

Oct 12 2022

bcr accepted D36407: ls: `-v` flag.

Manpage looks good now. Thank you!

Oct 12 2022, 4:00 PM

Oct 11 2022

bcr accepted D36931: Update committer numbers.

Looks good. Would be amazing if this would be updated automatically by a script of some kind.

Oct 11 2022, 1:30 PM

Oct 8 2022

bcr added a reverting change for rG1c2be25f6080: Add extra EINVAL information about wrong block size to read(2)/write(2): rG44b0b943b8f3: Revert "Add extra EINVAL information about wrong block size to read(2)/write(2)".
Oct 8 2022, 10:29 AM
bcr added a reverting change for D24617: Add additional EINVAL information about wrong block size to read(2)/write(2): rG44b0b943b8f3: Revert "Add extra EINVAL information about wrong block size to read(2)/write(2)".
Oct 8 2022, 10:29 AM
bcr committed rG44b0b943b8f3: Revert "Add extra EINVAL information about wrong block size to read(2)/write(2)".
Oct 8 2022, 10:28 AM

Oct 7 2022

bcr accepted D30351: ptrace: add an option to not kill debuggees on debugger exit.

OK from manpages.

Oct 7 2022, 6:11 PM
bcr committed R9:94f8098e1999: Remove whitespaces at end of line.
Oct 7 2022, 5:27 PM
bcr committed R9:a4c01d577a7e: Typo fix: stictly -> strictly.
Oct 7 2022, 4:37 PM
bcr committed R9:5acdd01ea951: Fix a typo: thouroughly -> thoroughly.
Oct 7 2022, 4:32 PM
bcr abandoned D19954: Remove reference to nonexistent npfctl from blacklistd man page.

Overcome by events, someone else removed the section by now.

Oct 7 2022, 2:22 PM
bcr accepted D28450: lualoader: add support for .lua configuration files.

Manpage looks good, we can do the filename markup in a followup commit.

Oct 7 2022, 2:19 PM
bcr added a comment to D32556: Add __FreeBSD_versions 1400037 and 1400038 to handbook.

The changes were already committed to the porters-handbook. You can close this review.
Thanks for submitting it anyway.

Oct 7 2022, 2:10 PM
bcr accepted D33477: ithread(9): update top-level description.

OK from manpages.

Oct 7 2022, 2:05 PM
bcr accepted D34502: libmd: export and document *Fd/*FdChunk interfaces.

Manpage looks good. Thanks!

Oct 7 2022, 2:02 PM
bcr accepted D34012: sysctl: Add -F option to display sysctl format, refactor for a function to display info options for and added test cases.

Confirm man page looks good.

Oct 7 2022, 1:53 PM
bcr accepted D35980: Add support for _CR3 critical standby (S3) threshold..

OK from manpages.

Oct 7 2022, 1:49 PM
bcr accepted D34308: Add sysctl hw.acpi and hw.acpi.acline descriptions.

OK for the man page change.
@ota_j.email.ne.jp: Can you update the rest so we can get this committed. Arigato!

Oct 7 2022, 1:46 PM
bcr committed rG1c2be25f6080: Add extra EINVAL information about wrong block size to read(2)/write(2).
Oct 7 2022, 11:40 AM
bcr closed D24617: Add additional EINVAL information about wrong block size to read(2)/write(2).
Oct 7 2022, 11:39 AM
bcr committed R9:3c9d9ad5416d: Typo fix.
Oct 7 2022, 10:46 AM
bcr committed R9:b0fd71122c01: Belatedly add the Aberdeen Hackathon in the 57 North Hacklab..
Oct 7 2022, 10:03 AM
bcr accepted D32957: nvmecontrol: improve namespace size unit of devlist command output.

Man page also looks good now.

Oct 7 2022, 9:20 AM
bcr accepted D33866: nvmecontrol: Add Micron Vendor Unique SMART logpage support.

Man page looks good, thanks!

Oct 7 2022, 9:18 AM

Oct 6 2022

bcr committed rG84e86788705c: nvmecontrol: Add Samsung Extended SMART Information logpage support (authored by wanpengqian_gmail.com).
Oct 6 2022, 10:38 AM
bcr closed D33749: nvmecontrol: Add Samsung Extended SMART Information logpage support..
Oct 6 2022, 10:37 AM

Oct 5 2022

bcr closed D20577: Add information on how to load GEOM_MIRROR into the kernel at boot time and while the system is running to the SYNOPSIS section of gmirror.8 .
Oct 5 2022, 4:51 PM
bcr committed rGd63104d253e2: Add information on how to load gmirror on boot to auto activate mirrors.
Oct 5 2022, 4:51 PM
bcr committed R9:3cceb0106c6c: Remove unnecessary line break in the sha256sum command example.
Oct 5 2022, 3:19 PM
bcr committed R9:a21f100e426e: Remove whitespace at end of some lines..
Oct 5 2022, 2:54 PM
bcr committed R9:b76576673c76: Fix checksum file names and verification instructions.
Oct 5 2022, 2:25 PM

Oct 1 2022

bcr added a comment to D22150: Update swapon.8 to discourage using ZFS as swap device/file..

Any updates on this one? The suggested changes don't seem too difficult to me.
@ota_j.email.ne.jp are you interested in finishing this?

Oct 1 2022, 9:06 AM
bcr accepted D27122: md(4): Stop symlinking vn.4 to md.4.

Looks good, can you commit this?

Oct 1 2022, 9:03 AM
bcr added a comment to D30004: Add sections to the handbook on cpu frequency control.

Can we get this committed? Seems mostly complete to me.

Oct 1 2022, 9:00 AM
bcr added a comment to D31315: lagg.4: note laggtype arg and reorder wireless example.

Any updates on this?

Oct 1 2022, 8:59 AM
bcr accepted D33749: nvmecontrol: Add Samsung Extended SMART Information logpage support..

Explicitly approve the man page change.
@imp: Can you take care of the commit? I associate nvmecontrol mainly with you and you have a src bit to do the commit. Thank you!

Oct 1 2022, 8:30 AM

Sep 30 2022

bcr accepted D31146: cron: Implement -s command option.

Approving the man page part.
Hope we can get it committed soon.

Sep 30 2022, 8:03 AM
bcr accepted D32128: Add support for sysctl.conf.d.

OK from manpages.
Would be good to see some progress on this.

Sep 30 2022, 8:00 AM · rc
bcr added a comment to D33749: nvmecontrol: Add Samsung Extended SMART Information logpage support..

Who's going to commit this? Seems like it's as complete as it can get.

Sep 30 2022, 7:57 AM
bcr added a comment to D35326: glabel.8: Warn against using generic labels on a shared device.

Can we move this along or do we still have to discuss something about it?

Sep 30 2022, 7:55 AM

Sep 29 2022

bcr accepted D36002: netlink: add netlink support.

Both man pages look good now. Thank you!

Sep 29 2022, 2:45 PM

Sep 28 2022

bcr added a comment to D36002: netlink: add netlink support.

Thanks for the man page and the huge work implementing netlink!
Can hyou run "mandoc -Tlint" over it? There are at least a couple of instances where there must be a line break inserted after a sentence stop.
I started commenting some occurances, but rather than doing all of them, it's probably easier to go via the mandoc output.

Sep 28 2022, 5:21 PM