In D35155#944705, @editor_callfortesting.org wrote:

Is this Review still valid, valuable, and ready to land?

predict_true macro removed, also fixed libsysdecode mktables

Thank you for fixing this

In D40479#942414, @freebsd_darkain.com wrote:

As I already mentioned, my test was done from a fresh installation off of a FreeBSD 14-CURRENT ISO image. Everything other than what I had described was 100% defaults.

compat.linux.emul_path: /compat/linux

I even went as far as to record a video of the copy-pastable repro instructions that I gave to show the issue.

www.youtube.com/watch?v=N46TGrCK4t8

In D41320#942212, @ehem_freebsd_m5p.com wrote:

Rebuild with 8920c5f2a11 reverted succeeded. Looks like D41320. The host is FreeBSD 13.2p2 with minimal extras.

In D41337#941279, @mjg wrote:

my bad, the entire point was for validation to happen prior any automagic assignment so filesystems are forced to explicitly state their position on fplookup for given vop vector

I disagree, it’s not an automagic, it is a long lived well known stable code, and, of course, the fix doesn't change the purpose you wanted

In D41338#941266, @mjg wrote:

does this pass the test suite from /usr/tests when backed by ufs?

SUBDIR_DEPENDS_stack

well, that's was John's test case, adapted to atf. I agree, that te test was a bit clumsy,
so, slightly rework it. AFAIU, the test changes the protection bits of the last page in the mmaped
stack area, then touches next page to gen PF.

Move stack tests to a separate directory under tests/sys/vm

In D41320#941149, @kib wrote:

I am not sure what your trouble is, but if it is about having the dependency .dso built before the test program, try to look at libexec/rtld-elf/tests/Makefile. Specifically SUBDIR_DEPEND_target= XXX.

John Carr test added

Seems done, thanks.

Done, thanks. Tinderboxd

In D41236#939212, @kib wrote:

I am curious, why don't you code this in pure C with ATF.

Done,
+ MAP_ANON

Just to say, all glibc stack related tests are passed now, thank you.