Reference: https://ci.freebsd.org/view/Test/job/FreeBSD-main-aarch64-test/1040/testReport/junit/lib.libexecinfo/sigtramp_test/test_backtrace_sigtramp/

In D54585#1248735, @markj wrote:

FreeBSD supports both. For cross-builds, on Linux it is defined as 0, and on macOS it is defined as 1 in their respective nbtool_config.h header files.

It is not clear what "it" refers to here.

What I'm currently looking for is opinions on what the time values should be before I continue adding mkimg tests. I have annotated what I believe should be the correct result with XXX comments. Do not worry about the actual fixes, as those are relatively trivial.

In D54550#1246328, @ngie wrote:

Oof... that's a bit of an increase. Wonder if there's a way to improve things a bit more perf wise (I'd file a bug to track the investigation).

References:

• https://ci.freebsd.org/view/Test/job/FreeBSD-main-aarch64-test/1873/testReport/junit/sys.geom.class.eli/online_resize_test/online_resize/
• https://ci.freebsd.org/view/Test/job/FreeBSD-main-aarch64-test/1873/testReport/junit/sys.geom.class.eli/reentrancy_test/init/
• https://ci.freebsd.org/view/Test/job/FreeBSD-main-aarch64-test/1873/testReport/junit/sys.kern/jailmeta/keyvalue_contention/
• https://ci.freebsd.org/view/Test/job/FreeBSD-main-aarch64-test/1873/testReport/junit/sys.mac.portacl/nobody_test/main/
• https://ci.freebsd.org/view/Test/job/FreeBSD-main-aarch64-test/1873/testReport/junit/sys.netpfil.pf/rules_counter/4G/
• https://ci.freebsd.org/view/Test/job/FreeBSD-main-aarch64-test/1873/testReport/junit/sys.fs.tarfs/tarfs_test/tarfs_large/
• https://ci.freebsd.org/view/Test/job/FreeBSD-main-aarch64-test/1873/testReport/junit/sys.fs.fusefs/io/main/ (This one needs further investigation)

Reference: https://ci.freebsd.org/view/Test/job/FreeBSD-main-aarch64-test/1873/testReport/junit/sys.netpfil.pf/killstate/src_dst/

In D54538#1246106, @ziaee wrote:

don't forget to fix the commit message typo!

Date will be bumped upon commit (if accepted).

I'll abandon this revision, as it is very specific to zsh. It is unlikely that someone else hits this issue. For it to happen, the root user must use zsh (unlikely).
zsh intentionally lowercases the error message (https://github.com/zsh-users/zsh/blob/6a691a3487cc26900475291ced12400318176aeb/Src/utils.c#L361-L368)

• Reduce duplication by abstracting the percent() function.

Update the manual page percentages as well.

Rebase.

• Remove stray reference to availheader

• Revert makfs_tests_common.sh

In D54427#1244546, @ngie wrote:

In D54427#1244543, @ngie wrote:

NAK on the "blind" atf_check removal: it makes potentially valid issues that should be tracked in test case runs into silent errors. You have to dig the prior test case output to try and piece together what went wrong after this change, making failures far more annoying or impossible to triage.

If you remove implied atf_check flags though, I'm game. I just don't want to ignore errors that shouldn't be ignored.

Address suggestions

• Address suggestions from https://reviews.freebsd.org/D54429#inline-322541 (remove default atf_check flags for clarity).

Rebase.

Address suggestions:

• Quote and cite the text from POSIX.
• Use an unsigned decimal number to express the percentage. Keep the current width of the field to avoid changing the spacing between columns.

In D54016#1243888, @des wrote:

In D54016#1243879, @jlduran wrote:

In D54016#1243870, @des wrote:

What's the point of copying the NetBSD tests if we end up having to change everything about them, and then end up adding our own test script anyway as you do in D54265?

I tried to #ifdef this test, but it soon became obvious we should branch out (it became unreadable).

Yes. Just write your own.

In D54424#1243918, @asomers wrote:

This looks fine. But as the default timeout is already 300s, I suggest increasing it even more. If it were me, I would double it.

In D54016#1243870, @des wrote:

What's the point of copying the NetBSD tests if we end up having to change everything about them, and then end up adding our own test script anyway as you do in D54265?

There is really no way to tell beforehand if this timeout is enough.
Reference: https://ci.freebsd.org/view/Test/job/FreeBSD-main-aarch64-test/1867/testReport/junit/usr.sbin.makefs/makefs_zfs_tests/file_extend/

There is really no way to tell beforehand if this timeout is enough.
Reference: https://ci.freebsd.org/view/Test/job/FreeBSD-main-aarch64-test/1867/testReport/junit/usr.sbin.makefs/makefs_zfs_tests/compression/

Thank you!
I wanted as few diffs with NetBSD as possible, but using nitems() is a good suggestion; I'll probably submit it to GNATS.