I am not dropping this discussion, just going to split this review up. Expect to see an updated review, with your comments addressed, in the next week or so

I'd like to move away from using static sizes and limits. This is fine as a stop-gap, but please consider changes that remove such static sizes.

In D15801#340849, @delphij wrote:

In D15801#336741, @eadler wrote:

Steal space from RES and SIZE; incrase username

I can't stress how much I hated this. It's 2018, can we do something smarter than assuming the terminal has a fixed width of 80 characters instead of squeezing space unconditionally?

(fwiw, If there only contentious part is the new words about private discussions, I'd like approval to commit the other parts first. This will make it easier to track and review)

private technical conversations:

• Reduce preachyness, and give more actionable advice.

For my edification: the two possible solutions to cast alignment are (a) memcpy and (b) aligned_alloc. The issue with the latter is that the compiler likely won't understand it, and thus still warn.

It is a bit late for me, so this is just an initial scan.

I had a memory of some utilities supporting any or -1 for "in a jail" (i.e. jid != 0). Might be worth looking at doing this too

too many files

In D15960#338171, @bcr wrote:

Would it make sense to add an EXAMPLES section that shows how to define a proper TOPCOLOR?

Thanks for your report. Fixed along with a couple of other issues noticed.

I am planning on committing this unless I hear otherwise by EoD today.

add documentation stub to remind me to write more

• top(1): reimplement header formatting as sbuf
• Steal space from RES and SIZE; incrase username
• reduce use of +1

Steal space from RES and SIZE; incrase username

rebase

rebase

In D15801#336271, @allanjude wrote:

In D15801#334441, @eadler wrote:

What do y'all think of making the username the maximum length username seen so far (up until a fixed max). This solves all known issues

• having to short username
• having too long username
• initialization being slow since it needs to iterate over a remote service
• having the column flicker due to a long username going in and out of use.

Where would you get the extra space to fit longer usernames?