yeah, without it the ampdu retry stuff eventually stops retrying until the counter loops around again for the comparison to work

I don't get the correlation between your commit message and these changes. Is there an actual change (due to casting) in this change? Or is there a problem "somewhere" but this change does not necessarily address that?

Your first line of commit message is RX repetitive; I assume one should be tx. Should be fixed before commit.

Changes:

• Removed unnecessary TSF insertion in probe response frames
• Removed pause() workaround for wpa_supplicant(8) race condition
• Added ic_cryptocaps configuration to declare supported cipher suites

Can you please create diffs with -U9999 if you manually upload them so there is context?

It wasn't clear from out last conversation if this is ready for review or if there is more related work.

more cleanups, inspired by bz's poking at this whole rssi/nf/signal strength cleanup.

Just dropping a note that this leads to ~10x throughput to pkg.f.o on my laptop -- previously averaging somewhere around ~2-3mbit/s due to constant out-of-order acks, up to ~25-30 mbit/s on average

Are you sure you are not getting full reassembled (re-aggregated) frames on your AX210 that better sees no sequence number checks in net80211 anymore?

Just see https://reviews.freebsd.org/D50929

@bz here's another great example of "almost but not quite what net80211 "expects" " ;-) sigh.. :)

comments from bz

Seems fine ..

I am reluctant to click on Request Changes for this but maybe you can still fix the local bits before committing.

Please update the bits available comment below keymgmt when you land this

Looks good to me

more "correct" fixes, i hope!

In D52523#1211903, @adrian wrote:

ok, I'd like to land this and then follow it up with some more iwx cleanups. Thanks for pointing them out though, I'm not shocked that the original upstream code was messy with key management too. ;-)

ok, I'd like to land this and then follow it up with some more iwx cleanups. Thanks for pointing them out though, I'm not shocked that the original upstream code was messy with key management too. ;-)

update from bz

This seems ok to me, if it doesn't smoke and you can still do vht then its a good step forward

right after the start of stab week seems like a good time to see if iwx explodes with these

Yes, applying that on top of unmodified main makes iwm(4) work again.

This fixes the AX210 in my frame.work that previously made it through association and DHCP, then stopped passing traffic. Thanks!

comment fixes

Do you also want to improve the IEEE80211_CRYPTO(9) man page?

update

In D52299#1194452, @bz wrote:

Based on your description it sounds more like you want to disable PS in net80211 and leave it to iwn?

Sorry, nothing new from you but the original driver already seems to have gotten the return code wrong; can you please double-check?

updates from bz

Looks good to me; ignoring 11be support this matches iwlwifi debug logic.