dbaio@ beat me to getting Azure CLI into ports :-)

This review is now too old, and way behind all the changes that happened to USES=python (especially the introduction of FLAVORS).

I think taking the simplest approach of slave ports for the libraries wine needs is the easiest. Are you thinking about any use case beyond wine?

Switch to using a slave port.

Thank you all for the useful ideas. I think the first price approach is to create 'lib32-' companion packages for the 32-bit libraries we need. To this end I have created a patch that adds this functionality: https://reviews.freebsd.org/D16830. Luckily the approach is minimally invasive and often involves:

1. Adding lib32 to USES
2. Sometimes replacing uses of ${PREFIX}/lib} with ${LIBDIR}, however lib32 already handles CFLAGS, CPPFLAGS, and CONFIGURE_ARGS (this can be extended as needed)
3. Sometimes adding USE_LDCONFIG=yes

Add missing Mk/Uses/lib32.mk file.

• Switch to using PyPI
• Remove the creation script
• Remove azure-cognitiveservices-vision-face (no PyPI package and not a dependency on any port)
• Manually change the version of azure-servicemanagement-legacy to align with PyPI
• Manually restore the "unordered" items in www/Makefile

In D13690#356530, @mat wrote:

This tool, here, Phabricator, is a code review tool, not a patch queue for things to be committed, which is what Bugzilla is for.
If you are not a committer, or do not plan to commit it yourself, it is best to always open a PR on our bugzilla in parallel so that the change actually goes in our pipeline.

We have two failures and three skipped ports. The failures are do to unfetchable files from upstream. This does not affect lua, but of the dependents. I consider this a success and will commit this patch sometime during the day.

Apologies, I've been sick. I've kicked of an exp-run: http://dbn.westeurope.cloudapp.azure.com/lua.html

Add non-generated files

FYI, commit messages require the full path to this review (your draft message [I assume] only includes the review number)

I cannot comment on the specifics of lua (i.e. do these changes work), I've never used lua and haven't tested it. However, I am happy with the above changes with the following comments:

1. I assume the indentation is correct, despite it not rendering correctly in Chrome
2. Please try to upstream all patches

I cannot comment on the specifics of lua (i.e. do these changes work), I've never used lua and haven't tested it. However, I am happy with the above changes with the following comments:

1. I assume the indentation is correct, despite it not rendering correctly in Chrome
2. Please try to upstream all patches (and well done on doing that for the previous version)

In D14721#348739, @mat wrote:

Side note.

All ports MUST build as a regular user.

We spent a lot of time making sure they all do, DO NOT add new ports that require being root, they will get removed at one point in the very near future.

The comments I mention are just suggestions. Happy for you to commit this patch without those changes.

Looks good to me :-)

All dependent reviews have been committed. We are now up-to-date with VS for Mac (give or take msbuild).

Committed in r473600