This question terrifies me to even ask.

Another thing ... lines 108-109

Thank you @cy. The other thing I'd like to do is ...

Revisiting. I need a solid way to test this.

fix typos caught by pauamma_gundo

Email sent to @kib

SPDX-License-Identifier on posixmqcontrol.1

• feedback from concussious
• feedback from pauamma_gundo
• trimmed some trailing blanks

• continue long line
• spaces around boolean OR
• simplify for-loop

• continue long line
• simplify for-loop

manpage feedback from @pauamma_gundo.com and @cy.

The option to set the maximum message size is -d or --depth. The option -s / --size is already taken for max message size. I've updated the text to use "maximum queue size" and "current queue size" in the general sense and using the word "depth" to specifically refer to the -d / --depth option.

dropped unnecessary typecast.

The O_CREAT variant of mq_open accepts S_ISUID, S_ISGID and S_ISVTX as well as S_IXUSR, S_IXGRP, S_IXOTH "execute" bits. Curiously enough, fchmod ignores S_ISUID and S_ISGID. I've not tried S_ISVTX. I'm inclined to let the tool accept these extra permission bits if only because mq_open takes them.

strto[u]l must parse whole string.

Abandoned.

New review here:

no single line functions

I'm having trouble aligning kib's comments with the patch files. I'll submit a new revision.

• permission bits.
• continuation uses four spaces (not tab).
• exit code for malloc failure.

Updated the mode bits formatting. Example:

copy/paste typo caused mode other 'x' bit to appear as 'r'

Following @kib's suggestion, utility was updated to format the mode bits ... and I just spotted a mistake. Stand by ...

more style(9) conformance

• unit test updated for new exit codes.
• indentation for continuation lines
• use tabs for indentation

applied checkstyle9.pl feedback.

posixmqcontrol.c has no obvious style problems and is ready for submission.

In D43813#999429, @imp wrote:

tools/build/checkstyle9.pl
Or clang-format from an llvm port

warnx/warnc logging.
convert errnos to exit codes from <sysexits.h>
replace BSD_VISIBLE with FreeBSD__ (for portability).
make use of <stdbool.h>
drop use of nullptr.
remove superfluous comments.
style-9 compliant comments.

Thank you - @kib and @imp - for the feedback and comments. This utility started out as a C++ program before being converted to C. Will work through the comments one at a time.

Here is /etc/rc patch to take advantage of new rcorder -p option:

Hi Chuck!