Thank you for the review!

Thank you for the review!

Remove is_admin = false in ufshci_ctrlr_submit_task_mgmt_request

Thank you!

Thank you for fixing this!

After this fix, the following two reviews have been rebased and are ready for approval:
https://reviews.freebsd.org/D54003
https://reviews.freebsd.org/D54004

rebase

rebase

Use device_suspend/device_resume

In D53375#1233119, @imp wrote:

OK. I understand adding the quirk. It may make sense for us to handle some of these 'probing' commands better in the future, but we have many others than the ones you've added. As such, lets go wit the the PIM_WLUN flag for now.

I'm sorry for being late. I completely forgot.

Reopen until the current comment is resolved.

Please approve this review again. Sorry for confusion.

This review has been split into the following 5 reviews. Please check the following reviews.
Sorry for the confusion.

Please accept again same commit: https://reviews.freebsd.org/D53919

• cam/scsi: Support well known logical unit
• ufshci: Enable WLUN scan
• cam/scsi: Add power condition support to START STOP UNIT
• ufshci: Add a check for WLUN during driver initialization

Thanks for the review~!

Oh, you left a review here. I'll reopen it.

We'll review each patch individually.
https://reviews.freebsd.org/D53376

This patch is ready for the review!

I will request a review for each commit individually to make reviewing easier.