Address feedback

See the newer patch in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266680

Ping? This idea is pretty useful for debugging, maybe it can be finished up and brought into the tree?

In D40362#918891, @jrtc27 wrote:

This is not a whitespace cleanup (with the exception of the two trailing spaces in the shell scripts). Single-statement if and for statements are allowed to omit the braces per style(9); in fact it's extremely common to omit them in FreeBSD code.

Move else onto the same line

This is the result of this change:

@jhb Can you take a look at this?

In D36459#829873, @allanjude wrote:

If you use . instead of sh thse local scripts would have more access to the environment variables.

Forgot to update this one after moving it

Add man page link to pw(8)

Update man page tags

Switch to printf(1) and prefer the encrypted one if both are set

Add man page update

Address feedback from allanjude@

@dteske ping?

Swap the name of the variables

Thanks this fixes my issue!

@dteske TYVM!

Squashed version

Try arc with "HEAD^^"

In D35355#802164, @dteske wrote:

The raw diff [1] looks funny. The "before" (line removed) doesn't match what is in head [2].

[1] https://reviews.freebsd.org/file/data/gpestj4gip62y5xbunh3/PHID-FILE-mrgzvmtcys7du2upsagn/D35355.vson.id106529.diff
[2] https://cgit.freebsd.org/src/tree/usr.sbin/bsdinstall/scripts/auto#n155

Aha, I got arc to do what I wanted!

Address feedback from dteske

In D35357#801606, @dteske wrote:

Can we discuss perhaps using K&R style naming?

That is to say, BSDINSTALL_SKIP_* instead of BSDINSTALL_*_SKIP -- it would go a long way to being able to more-easily grep-out the skippable options and also open the prefix to being used in other parts of bsdinstall that are unrelated (read: other scripts/functions)

Thanks for this, I ran into it awhile back and didn't have time to run it down!

Sorry, I overlooked the stable/13 commit, but I do not see it in stable/12..

Did this get MFCed?

In D34878#791469, @asiciliano wrote:

In D34878#791429, @brd wrote:

@asiciliano The reason I did it using a file is so that make(1) would detect a change a rebuild if you change the value and do another build.

@brd The review is ok, I posted some test to remember to myself and to ask to somebody, I had a similar situation in the past. I'm sorry if it was unclear and boring.

@asiciliano The reason I did it using a file is so that make(1) would detect a change a rebuild if you change the value and do another build.