Page MenuHomeFreeBSD

christos (Christos Margiolis)
User

Projects (1)

User Details

User Since
Jul 2 2021, 4:03 PM (238 w, 9 h)

Recent Activity

Thu, Jan 22

christos committed rG47917383c6d4: sound: Replace MIN() with min().
Thu, Jan 22, 9:09 PM
christos committed rG2bee4bb7f1b3: src.opts: Introduce MK_SOUND.
Thu, Jan 22, 9:09 PM
christos committed rG17ed747f1e2f: sndctl(8): Add libxo support.
Thu, Jan 22, 9:09 PM
christos committed rG0d33cdd04da7: sound: Unlock around uiomove() in midi_{read,write}().
Thu, Jan 22, 9:09 PM

Thu, Jan 15

christos added a comment to D54705: lib/virtual_oss: don't (over)link to libsamplerate.

By the way, there is a typo in the commit title ("vitual").

Thu, Jan 15, 5:58 PM
christos accepted D54705: lib/virtual_oss: don't (over)link to libsamplerate.
Thu, Jan 15, 5:58 PM
christos accepted D54704: vitual_oss: build system tidying.
Thu, Jan 15, 5:57 PM
christos committed rG37164224eefd: libexec/rc/rc.d/Makefile: Remove duplicate mixer entry.
Thu, Jan 15, 5:55 PM
christos committed rG241a43cf9da8: virtual_oss: Take MK_CUSE into account.
Thu, Jan 15, 5:55 PM
christos closed D54708: virtual_oss: Take MK_CUSE into account.
Thu, Jan 15, 5:55 PM
christos closed D54706: libexec/rc/rc.d/Makefile: Remove duplicate mixer entry.
Thu, Jan 15, 5:54 PM

Wed, Jan 14

christos updated subscribers of D54702: virtual_oss: remove needless .include in intermediate Makefile.

@ivy Makefile.inc defines:

PACKAGE?=	sound

Is it a problem if the inclusion is removed from here?

Wed, Jan 14, 1:41 PM
christos added a comment to D54704: vitual_oss: build system tidying.

Neither lib/virtual_oss nor usr.sbin/virtual_oss build with this patch:

root@freebsd:/mnt/src/lib/virtual_oss # make
Building /usr/obj/mnt/src/amd64.amd64/lib/virtual_oss/null/null.pico
In file included from /mnt/src/lib/virtual_oss/null/null.c:39:
/mnt/src/usr.sbin/virtual_oss/virtual_oss/int.h:33:10: fatal error: 'samplerate.h' file not found
   33 | #include <samplerate.h>
Wed, Jan 14, 1:39 PM
christos accepted D54703: virtual_oss: build commands/libs in parallel.
Wed, Jan 14, 1:37 PM
christos accepted D54702: virtual_oss: remove needless .include in intermediate Makefile.
Wed, Jan 14, 1:37 PM
christos requested review of D54708: virtual_oss: Take MK_CUSE into account.
Wed, Jan 14, 1:31 PM
christos requested review of D54706: libexec/rc/rc.d/Makefile: Remove duplicate mixer entry.
Wed, Jan 14, 1:27 PM
christos added a reviewer for D54503: linuxkpi: Add tag support to radix tree: christos.
Wed, Jan 14, 12:49 AM

Mon, Jan 12

christos committed rGf74f891581bc: src.opts: Introduce MK_SOUND.
Mon, Jan 12, 2:17 PM
christos closed D54456: src.opts: Introduce MK_SOUND.
Mon, Jan 12, 2:17 PM
christos added a comment to D54456: src.opts: Introduce MK_SOUND.

Congratulations and thanks for this great solution! It's now 100% compatible with the "WITHOUT_MODULES sound" kernel build and install knob and covers the entire sound toolkit.

Mon, Jan 12, 2:16 PM
christos added a comment to D54456: src.opts: Introduce MK_SOUND.

@zarychtam_plan-b.pwste.edu.pl @rozhuk.im-gmail.com Opinions?

Mon, Jan 12, 2:05 PM
christos committed rGeccd366b0a8b: sound: Replace MIN() with min().
Mon, Jan 12, 1:39 PM
christos added a comment to D50853: linuxkpi: Add eventfd_*().

Should this be committed now?

Mon, Jan 12, 1:34 PM
christos committed rGaa58af04dc88: sndctl(8): Add libxo support.
Mon, Jan 12, 1:33 PM
christos closed D54032: sndctl(8): Add libxo support.
Mon, Jan 12, 1:32 PM
christos added a comment to D54360: sound examples: Add MIDI kqueue example.

The USB stack seems to have a default kqfilter method,so I suppose this is why it works. Does it work properly though?

Almost perfectly in my testing. Problem is that kevent.data is always 0 and as kqueue is advertised as "after the fact" eventing system, it would be nice to get the event after all 3 bytes are ready. I'm speaking strictly about notes and controllers, but similar is true for any MIDI message: I'd like to receive event once the whole message is ready. In this code you'll notice I read 2 more bytes after initial read. That feels like magic, so it would be nice to get event.data = 3 and read the whole MIDI message at once.

Mon, Jan 12, 1:17 PM
christos updated the diff for D54456: src.opts: Introduce MK_SOUND.

Replace MK_VOSS with MK_SOUND after discussion with Mark.

Mon, Jan 12, 1:06 PM
christos retitled D54456: src.opts: Introduce MK_SOUND from virtual_oss: Create MK_VOSS option
Mon, Jan 12, 1:06 PM
christos added inline comments to D54503: linuxkpi: Add tag support to radix tree.
Mon, Jan 12, 12:47 PM
christos committed rG6b69d6726a7d: sound: Unlock around uiomove() in midi_{read,write}().
Mon, Jan 12, 11:27 AM
christos closed D54130: sound: Unlock around uiomove() in midi_{read,write}().
Mon, Jan 12, 11:27 AM

Sat, Jan 10

christos closed D54418: Status/2025Q4/audio.adoc: Add report.
Sat, Jan 10, 1:07 PM
christos committed R9:c29933c2d76f: Status/2025Q4/audio.adoc: Add report.
Sat, Jan 10, 1:07 PM
christos added a comment to D54359: sound: Add kqueue support to MIDI.

For testing you can use snd_dummy(4), I added some basic MIDI support, although you might need to make it more functional because it basically does more or less nothing currently.

Sat, Jan 10, 11:26 AM

Fri, Jan 9

christos committed rG60d93337caff: sound: Retire MIDIQ_DEBUG.
Fri, Jan 9, 11:33 PM
christos committed rG982dabce7247: sys/conf/files: Fix sndstat path.
Fri, Jan 9, 11:29 PM
christos committed rG0c7eb49acd36: sound: Merge chn_intr() with chn_intr_locked().
Fri, Jan 9, 11:29 PM
christos committed rGf3092142f9ba: snd_uaudio: Do not use pcm_channel->lock to protect uaudio_chan.
Fri, Jan 9, 11:29 PM
christos committed rG3ecd098ba4b1: sound: Retire unused snd_midi->name.
Fri, Jan 9, 11:29 PM
christos committed rG76a53e183957: sound: Allocate mpu401 with M_WAITOK.
Fri, Jan 9, 11:29 PM
christos committed rG2ded9e1e2538: sound: Get rid of unused MIDIQ macros.
Fri, Jan 9, 11:29 PM
christos committed rGefca6398b7eb: sound: Make mpu_if definitions static.
Fri, Jan 9, 11:29 PM
christos committed rG209cfbb4a9f7: sound: Get rid of unused midi/midi.c defines.
Fri, Jan 9, 11:29 PM
christos committed rG2a8f866ede21: sound: Retire mpu_callbackp().
Fri, Jan 9, 11:29 PM
christos committed rG3b9a2db3c2a5: sound: Move sndstat out of pcm/.
Fri, Jan 9, 11:29 PM
christos committed rG4fc99fc60def: sound: Do not check for NULL before free().
Fri, Jan 9, 11:29 PM
christos committed rG1cebe00c289f: sound: Take device type into account in sndstat.
Fri, Jan 9, 11:28 PM
christos committed rG0ed90f4379c4: sound: Improve snd_midi->{in,out}q allocation.
Fri, Jan 9, 11:28 PM
christos committed rGb11224d935a3: sound: Retire MIDI_DEBUG.
Fri, Jan 9, 11:28 PM
christos committed rGe4f214686bce: sound: Rename midi_cdevsw name to "midi".
Fri, Jan 9, 11:28 PM
christos committed rG7b86ef4a4f37: sound: Remove dead if-statement.
Fri, Jan 9, 11:28 PM
christos committed rG177ea29c6baf: sound: Retire snd_midi->busy.
Fri, Jan 9, 11:28 PM
christos committed rG8c005f3da817: sound: Merge midi_destroy() with midi_uninit().
Fri, Jan 9, 11:28 PM
christos committed rG99ed1fc93f44: sound: Retire snd_midi->qlock.
Fri, Jan 9, 11:28 PM
christos committed rG5d794b0d63ab: sound: Update midi/midi.* LICENSE.
Fri, Jan 9, 11:28 PM
christos committed rG9ad643ff2e50: snd_dummy: Initial MIDI support.
Fri, Jan 9, 11:28 PM
christos committed rG3e04a082687c: sound: Retire midi_devs and mstat_lock.
Fri, Jan 9, 11:28 PM
christos committed rG7154f9d06460: sound: Stop building midi as a module.
Fri, Jan 9, 11:28 PM
christos committed rG6511bb585517: sound: Get rid of unnecessary breaks.
Fri, Jan 9, 11:28 PM
christos committed rG4b01d9267818: sound: Retire unused pcm_feeder->align.
Fri, Jan 9, 11:28 PM
christos committed rG2985cba88f39: sound: Update pcm/feeder.h LICENSE.
Fri, Jan 9, 11:28 PM
christos committed rG353a529d3a75: sound: Retire pcm_feeder->desc_static.
Fri, Jan 9, 11:28 PM
christos committed rGed61d50bd404: snd_hda: Default to 256 when corb/rirb is invalid.
Fri, Jan 9, 11:28 PM

Wed, Jan 7

christos added a comment to D54456: src.opts: Introduce MK_SOUND.

Why MK_VOSS and not MK_VIRTUAL_OSS? I also don't really understand the rationale... sound-related utilities are not needed on some platforms, ok, but why not have a more generic option that also lets you remove sndctl and mixer?

Wed, Jan 7, 12:27 PM

Tue, Jan 6

christos added inline comments to D54488: linuxkpi: Implement <linux/seq_buf.h>.
Tue, Jan 6, 11:14 AM
christos accepted D54494: linuxkpi: Replicate the chain of #include in the `cec*.h` headers.
Tue, Jan 6, 11:10 AM
christos accepted D54493: linuxkpi: Add WARN_RATELIMIT().
Tue, Jan 6, 11:09 AM
christos accepted D54492: linuxkpi: Add <linux/kmsg_dump.h>.
Tue, Jan 6, 11:08 AM
christos accepted D54491: linuxkpi: Add <linux/font.h>.
Tue, Jan 6, 11:08 AM
christos accepted D54489: linuxkpi: Define `raw_spinlock_t` in <linux/spinlock.h>.
Tue, Jan 6, 11:06 AM

Fri, Jan 2

christos committed rG8c7a7d7df508: sys/conf/files: Fix sndstat path.
Fri, Jan 2, 5:47 PM
christos committed rG0794365d5d3c: sound: Merge chn_intr() with chn_intr_locked().
Fri, Jan 2, 5:22 PM
christos closed D54102: snd_uaudio: Do not use pcm_channel->lock to protect uaudio_chan.
Fri, Jan 2, 5:21 PM
christos committed rGc234740c9d34: snd_uaudio: Do not use pcm_channel->lock to protect uaudio_chan.
Fri, Jan 2, 5:21 PM
christos added a comment to D54359: sound: Add kqueue support to MIDI.

You can rebase it already. I just committed the patches.

Fri, Jan 2, 5:07 PM
christos committed rGfd1312d3629c: sound: Allocate mpu401 with M_WAITOK.
Fri, Jan 2, 4:59 PM
christos committed rGa9c3bb39bc91: sound: Retire unused snd_midi->name.
Fri, Jan 2, 4:59 PM
christos committed rG3f8a85a085c7: sound: Get rid of unused MIDIQ macros.
Fri, Jan 2, 4:59 PM
christos committed rG3094c5e388df: sound: Make mpu_if definitions static.
Fri, Jan 2, 4:59 PM
christos committed rGe3b57ceffef0: sound: Retire mpu_callbackp().
Fri, Jan 2, 4:59 PM
christos committed rG4a2d1532e841: sound: Get rid of unused midi/midi.c defines.
Fri, Jan 2, 4:59 PM
christos committed rGbafa8c951d8c: sound: Move sndstat out of pcm/.
Fri, Jan 2, 4:59 PM
christos committed rG792251295cdf: sound: Do not check for NULL before free().
Fri, Jan 2, 4:59 PM
christos committed rG2aa16666e2fa: sound: Take device type into account in sndstat.
Fri, Jan 2, 4:59 PM
christos committed rG3b9e776498a7: sound: Retire MIDIQ_DEBUG.
Fri, Jan 2, 4:59 PM
christos committed rGb9db6c212873: sound: Improve snd_midi->{in,out}q allocation.
Fri, Jan 2, 4:59 PM
christos committed rGc288595c4eac: sound: Retire MIDI_DEBUG.
Fri, Jan 2, 4:59 PM
christos committed rGd54c782fde63: sound: Retire snd_midi->busy.
Fri, Jan 2, 4:59 PM
christos committed rGd2baf9301be3: sound: Remove dead if-statement.
Fri, Jan 2, 4:59 PM
christos committed rGd6121f7b508b: sound: Rename midi_cdevsw name to "midi".
Fri, Jan 2, 4:59 PM
christos committed rGd912ea5879cd: sound: Merge midi_destroy() with midi_uninit().
Fri, Jan 2, 4:59 PM
christos closed D54140: sound: Move sndstat out of pcm/.
Fri, Jan 2, 4:59 PM
christos closed D54174: sound: Do not check for NULL before free().
Fri, Jan 2, 4:59 PM
christos committed rG4cc78f5dd7c2: sound: Retire snd_midi->qlock.
Fri, Jan 2, 4:59 PM
christos committed rGfb945a50e264: sound: Update midi/midi.* LICENSE.
Fri, Jan 2, 4:59 PM
christos committed rGe963472ef853: snd_dummy: Initial MIDI support.
Fri, Jan 2, 4:59 PM
christos closed D54141: sound: Take device type into account in sndstat.
Fri, Jan 2, 4:59 PM
christos closed D54131: sound: Improve snd_midi->{in,out}q allocation.
Fri, Jan 2, 4:59 PM
christos committed rGc508be8ca957: sound: Retire midi_devs and mstat_lock.
Fri, Jan 2, 4:59 PM