• Allow for VLAN filtering in VFs by re-adding capability flag.
• Add function prototype for ixgbe_tx_ctx_setup() to fix compilation error.

Rebase due to out-of-band commit to HEAD.

• Moved ixgbe_if_init() declaration into ixgbe_sriov.h since both if_ix.c and if_sriov.c include that header file and it's no longer declared for the VF driver that can't link to it anyway.

• Fixed dmac sysctl reporting negative value due to incompatible type.
• Adjusted other sysctl functions to use the correct handler function.

• Re-commit patches on top of commit from review D11712
• Move the stats updates to the admin update task.
• Removed setup_optics since it isn't useful code.
• Moved check for link from the timer context to the admin task.
• Changed iflib member for setting number of Tx/Rx queues in PF driver.
• Incorporated more of sbruno's suggestions for D11727 review.
• Removed SR-IOV code from the VF driver.

Perhaps a rename of the new files to reflect the technology/enhancement you are proposing? Most people won't associate Yandex with VLANs. Regardless, to really benefit FreeBSD in general, you should probably include patches to other drivers as well, since VLANs are not specific to Intel devices.

Regarding the redefinition of CSUM_TCP/etc., I see what Matt was doing in terms of having these defines mean something more than just a renaming of some other macro. And I like the intention of this; it mimics what the CSUM_TSO macro does. However, I removed those undef/defines from ix_txrx.c in favor of explicitly using, for example, "(CSUM_IP_TCP | CSUM_IP6_TCP)". Those lines still fit in 80 columns. :)

• Incorporated more of sbruno's suggestions for D11727 review.

I might be missing something, but that was what I modified before our Thursday morning meeting. It should be using the isc_n[rt]xqsets_max members now.

• Changed iflib member for setting number of Tx/Rx queues in PF driver.

From sbruno's comments:

• Moved check for link from the timer context to the admin task.
• Fixed resource ID setting for the admin task.
• Adjusted tso_tx to be u64 type.

Thanks. Review updated.

• Removed setup_optics since it isn't useful code.
• Added use for get_advertise.
• Changed module dependency from netmap to iflib.

• Move the stats updates to the admin update task.

A rebase on top of D11712.

• Added ifdi_if.h to the SRCs flag for compilation.

Committed in r320688

• Fixed unresolved symbol issue with ixv.

Another review will be created shortly to fit on top of D11232.

• Fixed a load error when trying to load ixv dynamically.

• Fixed version error.

• Removed "Frame Limit" flag as it seems unnecessary.

• Fixed compilation error with ixv when compiled dynamically.

• Fixed compilation issue with unused variables.

• Fixed updating OS stats issue in VF driver.

• Fixed stat updating issue for VF driver.

• Removed double definition of two functions.

• Added netmap file to makefiles.

• Removed code that is already performed in the iflib layer. This should help Tx function in the VF driver.

• Fixed some panics when using VF driver. The VF driver still doesn't work, however.

• Backed out M_IXGBE memory type for queue allocation. Using DEVBUF.

• Fixed compilation error for ixgbe_vf.c

• Fixed some compilation errors for if_sriov.c.

• Added files to Makefile for building.

• Add files to sys/conf/files list to build ix/ixv.

• Applied same ring accounting bug fix to ixv as was committed to the PF driver in previous commit.
• Modified ixv to indicate that we don't support full frame sizes when VLANs are enabled if the hardware is 82599 and jumbo frames is disabled.

• Fixed Report Status accounting not being reset when interface down/up'd.

• Building the drivers fails because of the malloc-type change I performed in a previous commit. Reverting that change.

• Fixed VF driver.
• Another attempt at fixing 2.5G reporting.

• Updated interrupt setup/servicing/detection to match OOT. This fixes the issue of the interface not coming back up after unplugging/re-plugging in the module/cable.

• Fixed reporting of 2.5G speeds

Replaced with D10293

• Moved code around to match if_ix.c and/or the OOT driver
• Wrapped KTR code with ifdef for those using GENERIC-NODEBUG

• Fixed legacy interrupt insta-panic
• Possibly fixed flow control functionality
• Bumped default ring sizes to previous default (2K)
• Fixed overtemp warning for appropriate PHYs
• VF driver has evolved, but not quite stable yet
• Legacy interrupt passes traffic, but a "lock order reversal" has been sighted. iflib ctx lock.

• Fixed compilation issue when PCIOV is not defined.
• Fixed issue with setting advertise speed correctly for DNV hardware.
• Applied some changes based off of smh's style suggestions.

Thanks for the feedback. I'll look into these suggestions.

• Fixed compilation error for the VF driver.

Abandoning for now. Will resubmit this patch along with many more changes in a different review.

Abandoning for now. Will resubmit this patch along with many more changes in a different review.

Abandoning for now. Will resubmit this patch along with many more changes in a different review.

I'm going to abandon/close it today after I ask Eric how to do that. :) This patch will show up again soon, but along with the rest of the changes I'm adding.

The csum variable holds the checksum, yes. But nothing in attach() uses it afterwards. We only care about the return value of the function. I think the csum variable was added originally because ixgbe_validate_eeprom_checksum(), at that time, required a non-NULL input parameter...maybe? But then over time it was enhanced to allow a NULL parameter for drivers that didn't care about the csum value itself, but just the pass/fail return value of the function. In other words, ixgbe_validate_eeprom_checksum() will only populate "csum" if it's non-NULL. Grep for "checksum_val" to see what I mean.

• Fixed compilation issue.

Does ixgbe compile with the first parenthesis missing?

Looks good to me.