User Details
User Details
- User Since
- Feb 4 2016, 9:41 AM (529 w, 3 d)
Aug 17 2023
Aug 17 2023
Aug 16 2023
Aug 16 2023
dwmalone added a comment to D40120: LinuxKPI: implement mul_u64_u64_div_u64().
Looks sensible to me. Minor observations:
- It will blow up with a division by zero if z = 0, however, that's probably the correct behaviour.
- The two checks for overflow are clever - if we overflow, then we have definitely exceed our invariant, and so need to do the reduce step.
- I've suggested recording one extra invariant above.
- I've run a few different versions of this test code, and it has always produced the correct answers, so I think it is working fine.
dwmalone added a comment to D40120: LinuxKPI: implement mul_u64_u64_div_u64().
Will have a look today.
Dec 12 2021
Dec 12 2021
This looks good to me - including a random hashseed seems like a great idea. I guess someday it might be neat to hash the fport and lport values, rather than xor them, but that should wait for another day if this has already been running in Netfilx.
Jul 29 2021
Jul 29 2021
May 25 2021
May 25 2021
Also looks good to me. Slightly pedantic suggestions:
Dec 13 2020
Dec 13 2020
Jan 28 2020
Jan 28 2020
Aug 4 2016
Aug 4 2016
Mar 6 2016
Mar 6 2016
dwmalone committed rS296424: MFC:.
Feb 23 2016
Feb 23 2016
Feb 18 2016
Feb 18 2016
dwmalone added a comment to D5186: pwd_mkdb opens files with O_SYNC instead of calling fsync.
Great - I'll commit it in the next day or two, and ask for permission to MFC.
Feb 4 2016
Feb 4 2016
