I had this in D48244 as well. @mat didn't like it and @cperciva pointed out that it can be a useful quick reference for finding out when something was implemented or changed.

I want to make sure all the issues are fixed there before anything gets MFCed.

Linux does seem to read these registers in a few places, but it's hard to see whether the bug is likely to cause problems.

It doesn't seem so, at least in FreeBSD. The only read of these registers I found is in arm_gic_db_show().

There's the same assertion earlier in the fn for the ts allocation.

Does nothing actually care about the return value today?

we aren't making any more assumptions in this change

I wonder if we want to add some validity checking on ph->p_memsz while we're here? I think a wrong p_memsz will be handled the same before/after this change so it's fine from that perspective, it's more general pondering about what if any validation rtld ought to do.

This seems reasonable to me

I think it's worth adding a comment as well -- https://reviews.llvm.org is deprecated and this review is never going to be updated or completed. I'm not sure if @dchagin or @arichardson have a rebased version of it but someone will need to pick it up.

Committed as dac74b20c706b1f73986fb40dac27ed85c1d2850

Yes let's push this into main and iterate on it from there if necessary

This needs a description for WITHOUT_SOUND in tools/build/options

Thanks!

device_printf will include the device prefix mfi so I'm not sure why it needs to be repeated, and I'm also not sure what value including FreeBSD in the message brings.
Including LSI, correctly capitalizing MegaRAID, and expanding version all sound good to me.

Contrary to my comment in the call I suppose aq(4) should be added here now as well.

https://git.tukaani.org/?p=xz.git;a=commit;h=865e0a3689a25a7ee8eecae1a34c1775e3aa676e
https://reviews.llvm.org/D129587

I've had to submit some fixes for this exact same #if defined(__linux__) && defined(__ELF__) elsewhere and we're probably going to have to continue chasing this down in various upstreams. IMO it's fine to commit this locally but we should also submit to OpenZFS and to BoringSSL (if not there already).

Yes, agreed on starting with an approximation that is as close as possible w/ pkgbase to what we have today.

After resume there is no response to pressing keyboard keys in the console, but switching between terminals works.

D54346 landed

A more general thought/question: maybe we want ${SRCTOP} ?

@cperciva any suggestion on the best way to test this / confirm that I haven't missed something?