If snapshots_changed property has local source for a filesystem or volume, this kernel patch will remove it after a snapshot is created or destroyed on that dataset. To list the affected datasets:

Would you mind opening a PR at https://github.com/openzfs/zfs for this?

Thanks for the patch. The fse and zstd warnings have been fixed in OpenZFS master already and I have just opened a pull request to fix the dnode warning. That way we can avoid patching. I will update the port when that goes in.

@rmacklem is it ok if we make parsecred return an int so we can fail to start when the creds are invalid? It feels wrong to merely log an error message and keep going when this is misconfigured.

openzfs* changes look reasonable to me.

Incorporated python depends feedback

Seems reasonable to me.

This looks good to me. I recall that Makefile.depend will be generated by whoever needs it and does not need to be committed if you aren't sure how to do it, but I don't see that in the committer's guide so I'm not sure where that idea came from. Hopefully someone else has input on that aspect.

This has been committed in 1603881667360c015f6685131f2f25474fa67a72 #11813 Allow pool names that look like Solaris disk names

@oshogbo when this looks good to you I can commit it along with cap_netdb in D24832.

Is there anyone else familiar with the VFS stuff going on here who can help with this review? It's over my head at the moment.

I'm restoring behavior that was removed by mistake, so awkward as it may be, this is how ifconfig already worked before I tidied it up.

Just waiting for approval on this.