Git branch: https://github.com/ifreund/freebsd-src/tree/pkg-shlib-paths

Git branch: https://github.com/ifreund/freebsd-src/tree/pkg-shlib-paths

Generalize for all libcompats

@jrtc27 I'd like some input from you here since you seem to be the most familiar with libcompats beyond compat32.

In D54792#1252353, @jrtc27 wrote:

Won’t that break the dependencies list if clang is itself 32-bit?

Oh, I see now that I assumed bsdinstall now uses /etc/pkg/FreeBSD.conf and overlooked the repos_dir = "/usr/share/bsdinstall/" line.

Superseded by 8e0b1a1c03a35a5db13e370cb3e62585d3db68e3

Superseded by 8e0b1a1c03a35a5db13e370cb3e62585d3db68e3

What is the goal of this change? Do you want to make it possible for the user to set a custom BSDINSTALL_PKG_REPOS_DIR without requiring them to name their repository FreeBSD-base? I think it would be more robust to add a BSDINSTALL_BASE_REPO_NAME environment variable instead to support that use-case.

If the sendmail package is removed and reinstalled, which currently happens on every upgrade due to pkg(8) split upgrade issues, smmsp will stop working because its open handle to /var/spool/mqueue is no longer valid after pkg removes and recreates this directory.

Agreed, I don't think I've touched this file in a copyrightable way.

I like this change.

In D52829#1207617, @ivy wrote:

In D52829#1207587, @ifreund_freebsdfoundation.org wrote:

Should we remove the --no-kernel option along with this change? I added it specifically for installing jails originally and don't see a use case for using --no-kernel but not --jail.

i didn't remove it because i wasn't sure if people might be using it already. but if it was only added in 15.0 then there's probably no reason to keep it.

Should we remove the --no-kernel option along with this change? I added it specifically for installing jails originally and don't see a use case for using --no-kernel but not --jail.

Fix documentation of NOPKGBASE (this got inverted by the rebase)

Rebase, resolving conflict from change to -DNOPKGBASE

rebase, resolve conflicts with change to -DNOPKGBASE

Fix bad rebase

I think this patch could use a bit more work than just updating for the -DNOPKGBASE change. It was written before package sets were added and it would be nice if we could leverage those rather than doing fragile regex-based matching.

In D51483#1203665, @cperciva wrote:

Actually, this is going to need some changes now that PKGBASE is the default and there's a new NOPKGBASE option. Should I just take over this patch?

I see one minor improvement that can be made to the code style, the change itself LGTM!

Other than one nit, this LGTM!

This LGTM.

Thanks for the patience with my reviews, the code LGTM!

Git branch: https://github.com/ifreund/freebsd-src/tree/install-media-package-sets

Replace some _s with -s that were overlooked.

In D52558#1200684, @ivy wrote:

i don't know how the actual media works here, but my assumption is that bootonly would include a pkg repository that pulls packages from pkg.freebsd.org; since that has all the sets, it should work fine. if there's media that has all of base but not src and src-sys, that's fine, as long as it also doesn't contain set-src (because that would create a broken dependency).

In D52558#1200444, @ivy wrote:

i don't really like the idea that selecting more options installs less software, this feels unintuitive.

Git branch: https://github.com/ifreund/freebsd-src/tree/src-tests-sets

Git branch: https://github.com/ifreund/freebsd-src/tree/src-tests-sets

It's very nice to reduce the amount of fragile string matching here!

Add BSDINSTALL_PKG_REPOS_DIR to user_env_vars

Don't hardcode "worldstage"

Improve new dialog wording, rename HAVE_BASE_PACKAGES to HAVE_OFFLINE_BASE_PACKAGES for clarity.

While /usr/local/etc/pkg/repos/ exists, /etc/pkg/repos/ does not.

In D51916#1186602, @cperciva wrote:

This is a step in the right direction, but I still think that we want to end up with this being part of the pkg-bootstrap package.

Git branch: https://github.com/ifreund/freebsd-src/tree/bsdinstall-custom-repo

Git branch: https://github.com/ifreund/freebsd-src/tree/bsdinstall-base-conf

Currently pkgbasify puts this config in /usr/local/etc/pkg as well. I'll update pkgbasify for consistency as soon as this patch is landed (assuming it is accepted).

I opened https://reviews.freebsd.org/D51916 to make bsdinstall put FreeBSD-base.conf in /etc/pkg as well.

Move to /etc/pkg

In D51516#1176959, @cperciva wrote:

This seems like it should go into /etc/pkg?

Remove superfluous /dev/stdin usage

Always do an initial default package filtering

This LGTM!

Git branch: https://github.com/ifreund/freebsd-src/tree/pkgbase-vm-images

Git branch: https://github.com/ifreund/freebsd-src/tree/pkgbase-vm-images

Git branch: https://github.com/ifreund/freebsd-src/tree/pkgbase-vm-images

Git branch: https://github.com/ifreund/freebsd-src/tree/installer-kernel-man-fix

@ivy I've tested that this change works as expected with the existing installer scripts and merely causes the kernel man pages to not be installed by the installer (though the user can of course manually install them later).

In D51504#1176486, @ivy wrote:

In D51504#1176479, @ifreund_freebsdfoundation.org wrote:

Would you like to include this in your patch or should I submit a separate patch?

thanks! if you don't mind, i think it would make more sense for you to land that as you can definitely test it better than i can :-)

i'm not sure how the timing works out but, if no one objects to D51490 i'll probably land both that and this change later today (GMT+1) as i have a few other changes queued up that depend on MANGROUPS. i'm not too bothered if there's a brief period between then and when you land the installer changes as long as nothing actually breaks.

Install FreeBSD-kernel-man