In D44291#1012500, @jrm wrote:

In D44291#1012493, @jfree wrote:

Hey @jrm, efnet seems to be down so I can't ask you this over IRC. I keep getting freefall build failures for i386-quarterly. Would it be ok to push my changes to the relevant quarterly branches?

Hi Jake. In general, if an independent commit fixes a build, committing the fix to the quarterly branch is reasonable. I included "independent" because the commit that fixes the build may depend on many other commits that are only in the latest branch. In that case, we may want to wait until the start of the next quarter to avoid too much churn in the quarterly branch. If this update does fix the build on i386, don't forget to remove NOT_FOR_ARCHS=i386.

Hey @jrm, efnet seems to be down so I can't ask you this over IRC. I keep getting freefall build failures for i386-quarterly. Would it be ok to push my changes to the relevant quarterly branches?

Update manual page .Dd date

Update manual page .Dd date

• Included portfmt's suggestions thanks to Joe
• Version change from v0.17.0 to v0.17.1

• Record *namei* violations instead of vfs. Slight wording change for clarity.
• Rebase on main after several months

• Rename all instances of CAPFAIL_VFS to CAPFAIL_NAMEI
• Rebase on main after several months

• Address Mark's comments
• Rebase on main after several months

Replace all instances of "AT_FDCWD" with "<AT_FDCWD>" when reporting a violation via ktrcapfail().

In D40677#988214, @markj wrote:

I would frown at that. :) It introduces hidden control flow which makes it hard to see quickly what a function does.

Consider the common case where a function allocates some memory and is supposed to free it before returning: if I'm reviewing the code and want to verify it behaves properly with respect to that free() call, it's much easier to check if I just have to look for the "return" keyword in the function.

Once in a while it's handy, but it should be avoided if possible.

Actually, scratch that. I just understood your comment and this is a better solution.

It feels wrong to return inside of a macro, but I did not see any comments about it in style(9). This seems to be the solution that is most elegant in minimizing code duplication. Let me know your thoughts.

@jrm Would you mind pushing this? I'm on vacation and forgot to copy my ssh key from my desktop before I left. Sigh.

• Update version from 0.16.2 to 0.16.3.
• Add NOT_FOR_ARCHS=i386 to avoid building on i386.

I read through the pkg-fallout logs and I think the build failure on i386 is a FreeBSD Rust issue, unrelated to this port. I do not have the time to debug this further right now, so I'm going to add the NOT_FOR_ARCHS=i386 line.

In D43294#986818, @jrm wrote:

Looks good, but I see a build failure on 13i386. The easy workaround is to add NOT_FOR_ARCHS=i386.

Here is an excerpt from http://pkg.ftfl.ca/data/13i386-default/2024-01-03_09h20m47s/logs/errors/spotify-player-0.16.2.log.

fatal runtime error: Rust cannot catch foreign exceptions
thread 'coordinator' panicked at compiler/rustc_middle/src/util/bug.rs:36:26:
/wrkdirs/usr/ports/lang/rust/work/rustc-1.74.1-src/compiler/rustc_codegen_ssa/src/back/write.rs:1594:29: worker thread panicked
stack backtrace:
error: could not compile `spotify_player` (bin "spotify_player")

Caused by:
  process didn't exit successfully: `CARGO=/usr/local/bin/cargo CARGO_BIN_NAME=spotify_player CARGO_CRATE_NAME=spotify_player CARGO_MANIFEST_DIR=/wrkdirs/usr/ports/audio/spotify-player/work/spotify-player-0.16.2/spotify_player CARGO_PKG_AUTHORS='Thang Pham <phamducthang1234@gmail.com>' CARGO_PKG_DESCRIPTION='A Spotify player in the terminal with full feature parity' CARGO_PKG_HOMEPAGE='' CARGO_PKG_LICENSE=MIT CARGO_PKG_LICENSE_FILE='' CARGO_PKG_NAME=spotify_player CARGO_PKG_README=../README.md CARGO_PKG_REPOSITORY='https://github.com/aome510/spotify-player' CARGO_PKG_RUST_VERSION='' CARGO_PKG_VERSION=0.16.2 CARGO_PKG_VERSION_MAJOR=0 CARGO_PKG_VERSION_MINOR=16 CARGO_PKG_VERSION_PATCH=2 CARGO_PKG_VERSION_PRE='' CARGO_PRIMARY_PACKAGE=1 LD_LIBRARY_PATH='/wrkdirs/usr/ports/audio/spotify-player/work/target/release/deps:/usr/local/lib' /usr/local/bin/rustc --crate-name spotify_player --edition=2021 spotify_player/src/main.rs --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat --crate-type bin --emit=dep-info,link -C opt-level=3 -C panic=abort -C lto -C codegen-units=1 -C debuginfo=1 --cfg 'feature="librespot-connect"' --cfg 'feature="librespot-playback"' --cfg 'feature="media-control"' --cfg 'feature="portaudio-backend"' --cfg 'feature="souvlaki"' --cfg 'feature="streaming"' --cfg 'feature="windows"' --cfg 'feature="winit"' -C metadata=842a5826db0fb510 -C extra-filename=-842a5826db0fb510 --out-dir /wrkdirs/usr/ports/audio/spotify-player/work/target/i686-unknown-freebsd/release/deps --target i686-unknown-freebsd -C linker=cc -L dependency=/wrkdirs/usr/ports/audio/spotify-player/work/target/i686-unknown-freebsd/release/deps -L dependency=/wrkdirs/usr/ports/audio/spotify-player/work/target/release/deps --extern anyhow=/wrkdirs/usr/ports/audio/spotify-player/work/target/i686-unknown-freebsd/release/deps/libanyhow-492e95592132e846.rlib --extern async_trait=/wrkdirs/usr/ports/audio/spotify-player/work/target/release/deps/libasync_trait-eca6456b894ce27c.so --extern backtrace=/wrkdirs/usr/ports/audio/spotify-player/work/target/i686-unknown-freebsd/release/deps/libbacktrace-f57ec322f0894034.rlib --extern chrono=/wrkdirs/usr/ports/audio/spotify-player/work/target/i686-unknown-freebsd/release/deps/libchrono-acc36c673ba0f08f.rlib --extern clap=/wrkdirs/usr/ports/audio/spotify-player/work/target/i686-unknown-freebsd/release/deps/libclap-60ee68e025a5e10f.rlib --extern clap_complete=/wrkdirs/usr/ports/audio/spotify-player/work/target/i686-unknown-freebsd/release/deps/libclap_complete-30f3c0217e28ae2b.rlib --extern config_parser2=/wrkdirs/usr/ports/audio/spotify-player/work/target/i686-unknown-freebsd/release/deps/libconfig_parser2-d438472295b8cdf9.rlib --extern crossterm=/wrkdirs/usr/ports/audio/spotify-player/work/target/i686-unknown-freebsd/release/deps/libcrossterm-15dc999b95cc1ad1.rlib --extern dirs_next=/wrkdirs/usr/ports/audio/spotify-player/work/target/i686-unknown-freebsd/release/deps/libdirs_next-02326dcb3231e062.rlib --extern flume=/wrkdirs/usr/ports/audio/spotify-player/work/target/i686-unknown-freebsd/release/deps/libflume-47a756dbfdc912d2.rlib --extern librespot_connect=/wrkdirs/usr/ports/audio/spotify-player/work/target/i686-unknown-freebsd/release/deps/liblibrespot_connect-50ea358dd123aa2f.rlib --extern librespot_core=/wrkdirs/usr/ports/audio/spotify-player/work/target/i686-unknown-freebsd/release/deps/liblibrespot_core-cc2808a70f134f6f.rlib --extern librespot_playback=/wrkdirs/usr/ports/audio/spotify-player/work/target/i686-unknown-freebsd/release/deps/liblibrespot_playback-d8f8adce0273d879.rlib --extern log=/wrkdirs/usr/ports/audio/spotify-player/work/target/i686-unknown-freebsd/release/deps/liblog-52ca4419f4151259.rlib --extern maybe_async=/wrkdirs/usr/ports/audio/spotify-player/work/target/release/deps/libmaybe_async-b4f208a4b0e125db.so --extern once_cell=/wrkdirs/usr/ports/audio/spotify-player/work/target/i686-unknown-freebsd/release/deps/libonce_cell-482f28c6cd93cfac.rlib --extern parking_lot=/wrkdirs/usr/ports/audio/spotify-player/work/target/i686-unknown-freebsd/release/deps/libparking_lot-d8248febb18213d7.rlib --extern rand=/wrkdirs/usr/ports/audio/spotify-player/work/target/i686-unknown-freebsd/release/deps/librand-78475f571f4b4aec.rlib --extern tui=/wrkdirs/usr/ports/audio/spotify-player/work/target/i686-unknown-freebsd/release/deps/libratatui-c7bb9188981c8543.rlib --extern regex=/wrkdirs/usr/ports/audio/spotify-player/work/target/i686-unknown-freebsd/release/deps/libregex-544d63dea77fe560.rlib --extern reqwest=/wrkdirs/usr/ports/audio/spotify-player/work/target/i686-unknown-freebsd/release/deps/libreqwest-f04879bc79d3cf23.rlib --extern rpassword=/wrkdirs/usr/ports/audio/spotify-player/work/target/i686-unknown-freebsd/release/deps/librpassword-be83209b7548322d.rlib --extern rspotify=/wrkdirs/usr/ports/audio/spotify-player/work/target/i686-unknown-freebsd/release/deps/librspotify-d5494f75020f48dc.rlib --extern serde=/wrkdirs/usr/ports/audio/spotify-player/work/target/i686-unknown-freebsd/release/deps/libserde-edc3dcd9604a350e.rlib --extern serde_json=/wrkdirs/usr/ports/audio/spotify-player/work/target/i686-unknown-freebsd/release/deps/libserde_json-2772e51251182b23.rlib --extern souvlaki=/wrkdirs/usr/ports/audio/spotify-player/work/target/i686-unknown-freebsd/release/deps/libsouvlaki-c014ac77b78d1997.rlib --extern tokio=/wrkdirs/usr/ports/audio/spotify-player/work/target/i686-unknown-freebsd/release/deps/libtokio-3fe91b33c7fa1ca1.rlib --extern toml=/wrkdirs/usr/ports/audio/spotify-player/work/target/i686-unknown-freebsd/release/deps/libtoml-d20ca67802cbd3ca.rlib --extern tracing=/wrkdirs/usr/ports/audio/spotify-player/work/target/i686-unknown-freebsd/release/deps/libtracing-e68690b439812601.rlib --extern tracing_subscriber=/wrkdirs/usr/ports/audio/spotify-player/work/target/i686-unknown-freebsd/release/deps/libtracing_subscriber-b20445ea9a897d94.rlib --extern ttl_cache=/wrkdirs/usr/ports/audio/spotify-player/work/target/i686-unknown-freebsd/release/deps/libttl_cache-195711d19044f579.rlib --extern winit=/wrkdirs/usr/ports/audio/spotify-player/work/target/i686-unknown-freebsd/release/deps/libwinit-2f7284f3133e8e8d.rlib -C link-arg=-fstack-protector-strong -L native=/usr/local/lib -L native=/usr/lib -L native=/usr/local/lib` (signal: 6, SIGABRT: process abort signal)
*** Error code 101

In D42640#973086, @jrm wrote:

Good to see this made it into the tree. The Committer's Guide describes helpful metadata, such as Approved by: and Differential Revision: to include in your commit logs. See https://docs.freebsd.org/en/articles/committers-guide/#_include_appropriate_metadata_in_a_footer. Differential Revision: is helpful to refer a commit to review, and it also automatically closes the review after the commit. There is a commit log template you can install. See https://docs.freebsd.org/en/articles/committers-guide/#git-mini-primer-getting-started.

Hey @markj. Need approval to commit.

In D42456#969094, @imp wrote:

Do we have old commits to change to the FreeBSD address?

I created this patch to make the Capsicumization experience less intimidating for inexperienced developers. Both David and Mariusz may not be the target audience for this change because they already know how to extract the information that the tracing provides. Developers that are unfamiliar with Capsicum's semantics could use this tracing mode to easily determine why their program is not working in capability mode. I think it provides a solid starting point so new developers don't get lost and discouraged.

Again, maybe I just need some more context to understand the reasoning behind this change.

Reword comment to say the namespace instead of just namespace.

Update to avoid rebase conflicts.

Update to avoid rebase conflicts.

Create a new cap_filed structure and accompanying cfiled SLIST for filed integrity verification in libcasper's cap_p_open().

Create filed nvlist directly from readconfigfile() and address Mark's comments.

Add comment explaining intentional namespace pollution.

This patch has been applied to src under commit af93fea710385b2b11f0cabd377e7ed6f3d97c34.

This patch was getting long, as @bsdimp pointed out. Split it into three separate patches. This patch will still define the locking regime.

Include <sys/time.h> instead of <sys/timespec.h>. This causes intentional namespace pollution that mimics Linux.

• Remove locking around knlist_add() and set islocked arg to 0
• Add space under declarations in timerfd_getboottime()

• Do not initialize tfd_lock with MTX_RECURSE.
• Add assertion in filt_timerfdread(), showing that the tfd_lock is held.
• Place tfd_count in kn->kn_data.

In D41600#948035, @kib wrote:

Recursive locks is much harder to reason about and correctly use. In this case there is no sense in making the lock recursive, at worst you should add assertions instead of acquiring it more than needed.