In D53089#1244212, @gallatin wrote:

In D53089#1244032, @adrian wrote:

what are you seeing? I remember ixl RSS being buggy!

A valid rss type set with a 0 flowid for connections nginx accepts. Not sure why ixl can't calculate a proper hash in that case, but it can be worked around by checking to see if the flowid (rss hash result) is valid.

See https://reviews.freebsd.org/D54442

The module will build only on 64-bit arch (amd64 and powerpc64 was already there, this patch adds arm64). I don't think it was ever tested on 32-bits, and I don't have too many spare cycles to look into that.

Actually it was submitted on Monday 12/08, so before the Bugzilla PR was opened, but since whole libxo support in devinfo was reverted I guess it's not needed anymore.

Enable building the driver as a module.

Hey, @imp @ktullavik_gmail.com, Could you please take a look at this?

@kbowling, @erj Could you please take a look? I'd like to commit this when we get a green light from validation team.

Thank you for your work on optimizing iflib!

Thank you! LGTM

Fix reviewers list.

Fix assertion condition. It should be the expected state, not the opposite.

Wake-on-Lan configuration is not available for VFs.

In D52782#1206718, @erj wrote:

Can you tell us what the hardware enhancements are? 👀

This file might be a collateral damage of splitting PF and VF drivers on Linux. We should have all definitions from this file in other places, but let me double check if there are no differences.

In my testing it also looks good, both on PF and VF.

@jmg thank you for the patch! I started working on that issue, but a family emergency put me AFK for almost 2 weeks. To avoid further delay I think we should proceed with your version. It looks good to me, but let me run some basic tests on Monday. I'll approve this review as soon as I'm done.

Thanks again!

Fixing Eric's comment about codename seemed as a trivial change so I tried to do it without engaging Yogesh and updating the review. I'm sorry, it looks like it was a poor idea. Commit wasn't automatically detected by Phabricator and this review is still open. Is there anything else I should do except for adding the commit with 'Edit Related Objects', and promising to not try to cut the corners in the future?

@erj @kbowling - We've got a green light from our validation team. Could you please take a look at latest updates?

Abandoning this revision as related Github PR was merged by @imp