User Details
- User Since
- Jan 24 2015, 12:39 AM (514 w, 5 d)
Dec 13 2020
Jun 1 2018
May 12 2018
May 11 2018
May 9 2018
One needs to Jeff's uncommitted locking changes to see any benefit from this if one touches any pages in the mapping and even then it's only a ~20% win because there is then so much contention on the vm page queue mutex. Jeff is hesitant to sink too much energy in to this on behalf of a microbenchmark. There are clear wins to be had elsewhere without the complexity and risk of VM, so dropping this for now.
May 8 2018
LGTM
May 7 2018
May 4 2018
@lstewart ping
Hi Andi -
Thanks for the prompt response. I will definitely be taking a look at the upstream version. All I've done so far is add table generation to the build process and use the generated tables to provide sane default sampling rates . https://reviews.freebsd.org/D15275
May 3 2018
@kib Thanks. If I touch a page in the mapping that would be more representative correct? Page faults appear to be globally serialized by the per-domain reservations mutex, so that would likely scale no better than the no-op case without your change or mine.
Actually - @cognet could you please fix man page installation for ck?
It looks like the man pages aren't installed for ck. I'll submit a review for that.
! In D15231#321789, @kib wrote:
Where is the documentation for the ck epoch, both interface and implementation.
@shurd does this still work or should it be abandoned?
We needed to refine this further at ISLN.
@lstewart is this worth updating or should I just abandon?
I don't anticipate finding the time to add USERPTR support any time soon.
remove bogus license tags, the source is clearly BSD from Intel
rebase
Fix compile issues on non tier 1 architectures
May 2 2018
Apr 30 2018
Fix various panics under v6 as well as world build issue
Apr 28 2018
- spinlock_{enter, exit} are only gratuitous in functions only called from hardclock.
- add copyright to the two heavily modified files
Apr 25 2018
remove gratuitous spinlock_{enter,exit} calls
- make buffer count a function of the number of cpus
- allocate buffers and per-cpu structures from the right domain
- reduce nsamples to the number required assuming at most ~8 samples per tick
Apr 23 2018
Fix most false sharing in pmc
Apr 22 2018
Apr 11 2018
Apr 9 2018
- check watchdog and reset flags with lock held
- clear watchdog flag
@markj you can find my attempt at that here https://github.com/mattmacy/networking/tree/projects/witnessfix2 -- you can have a go at it. If you don't have the time / inclination I'd _really_ appreciate it if we didn't let the best become the enemy of the good. If we want stacks of reversals we can comment out blessed entries.
add v6 support and witness update
Apr 8 2018
Don't include extra changes
fix typo
add full context
add mls->mls_lock + dl->dl_lock
Apr 6 2018
Split in to many separate reviews.