User Details
User Details
- User Since
- Oct 21 2014, 4:41 PM (596 w, 6 d)
Jan 5 2021
Jan 5 2021
Not the author of this particular code, but LGTM.
Dec 13 2020
Dec 13 2020
Jun 8 2020
Jun 8 2020
Jan 20 2020
Jan 20 2020
marcel added a comment to D23010: usr.sbin/bhyve: Implement a generic block store backend interf..
Oct 18 2019
Oct 18 2019
marcel added a comment to D22068: mkimg: make MBR and EBR honor alignment, and change default alignment to 4k.
Copy-pasted the email sent to mjg@, since it bounced:
marcel accepted D22068: mkimg: make MBR and EBR honor alignment, and change default alignment to 4k.
As relayed via email: the changes are good. Please make them using independent commits. No need to send new reviews out. Thanks for fixing up the man page!
Oct 17 2019
Oct 17 2019
marcel added a comment to D22068: mkimg: make MBR and EBR honor alignment, and change default alignment to 4k.
Would you mind splitting the changes into 2 reviews/commits. I don't oppose the changes, but they are logically unrelated/independent and it helps us with reversals and/or MFCs if they are separate commits.
Aug 29 2019
Aug 29 2019
D21390: Fix address annotation in xml output from w is now accepted and ready to land.
Sorry for the delay. LGTM.
Aug 21 2019
Aug 21 2019
D21211: Change w(1) to compute FROM (host) field size dynamically is now accepted and ready to land.
Resolving stalemate.
marcel removed a reviewer for D21211: Change w(1) to compute FROM (host) field size dynamically: cem.
Aug 12 2019
Aug 12 2019
marcel added a comment to D21211: Change w(1) to compute FROM (host) field size dynamically.
Let me go back to the beginning in an attempt to unravel this. Let's start with Conrad's question:
"Isn't changing the output of w a POLA violation?"
Jul 4 2019
Jul 4 2019
Jun 30 2019
Jun 30 2019
Jun 29 2019
Jun 29 2019
marcel added inline comments to D20733: Lock busdma operations and serialize detach with open/close.
D20733: Lock busdma operations and serialize detach with open/close now requires review to proceed.
Use sx instead of mtx to allow M_WAITOK allocations
Jun 24 2019
Jun 24 2019
Mar 23 2019
Mar 23 2019
marcel committed rS345436: MFC 344826:.
marcel added a reverting change for rS254095: gpt_entries is used as limit for the number of partition entries in: rS345434: MFC 344790:.
marcel committed rS345434: MFC 344790:.
Mar 22 2019
Mar 22 2019
marcel committed rS345428: MFC 344826:.
marcel committed rS345427: MFC 344790:.
marcel added a reverting change for rS254095: gpt_entries is used as limit for the number of partition entries in: rS345427: MFC 344790:.
Mar 9 2019
Mar 9 2019
Mar 5 2019
Mar 5 2019
