Is this behavior desirable? It seems very ambiguous to me...

Oof... that's a bit of an increase. Wonder if there's a way to improve things a bit more perf wise (I'd file a bug to track the investigation).

Abandoning as @mm is planning on cutting a new libarchive release soon which will include this fix (and others).

Ship it!

sys/modules/asmc/Makefile: condense SRCS

In D41705#1244931, @ngie wrote:

I scrolled back several releases to see what our prior "Open Issues" sections look like.

In D54512#1245481, @ngie wrote:

BTW, isn't the proposed change what Errata Notes sort of do...?

BTW, isn't the proposed change what Errata Notes sort of do...?

Sorry for the delayed review on this. LGTM!

This is an interesting project. If we put this in tree, FreeBSD should really adopt mfsbsd from @mm and do a full vendor import for the component.

(here are some suggested changes to help get the process going..)

In D54427#1244543, @ngie wrote:

NAK on the "blind" atf_check removal: it makes potentially valid issues that should be tracked in test case runs into silent errors. You have to dig the prior test case output to try and piece together what went wrong after this change, making failures far more annoying or impossible to triage.

NAK on the "blind" atf_check removal: it makes potentially valid issues that should be tracked in test case runs into silent errors. You have to dig the prior test case output to try and piece together what went wrong after this change, making failures far more annoying or impossible to triage.