User Details
- User Since
- Jun 2 2014, 3:47 PM (549 w, 4 d)
Dec 1 2021
Nov 30 2021
We can only guess as to what may be really going on in the virtual device, but this seems like a correct defensive approach to what has been observed. Given the data at https://people.freebsd.org/~avg/vmxnet3-fragment-overrun.txt (thanks for collecting this!), I was concerned that there might be an issue with the fact that the virtual device is consuming free list entries for the zero-length fragments, but we are hiding this information from iflib, and that might break free list maintenance. I reviewed those paths, and it's fine (iflib tracks and replaces packet mbufs sent to the stack via a bitmap, provides the corresponding free list indexes to the driver during refill, and during refill, the vmx driver correctly identifies and handles gaps in those provided indexes).
May 19 2021
This is the right fix for what is a mistaken partial edit that occurred when parent determination was pulled up into eval_pfqueue() during 1d34c9dac8624c5c315ae39ad3ae8e5879b23256.
Apr 26 2021
Mar 17 2020
Mar 16 2020
Mar 14 2020
Mar 10 2020
This kills the refill limit entirely.
Mar 4 2020
Mar 3 2020
Jan 15 2020
Looks good to me.
Jan 13 2020
Jan 12 2020
I have updated bug 242890 to include the rationale for enabling (and also modifying) the #ifdef notyet RSS code when converting the driver to iflib, and also raised the question of whether this same issue exists for the bnxt driver.
Mar 14 2019
Feb 18 2019
Feb 17 2019
Feb 12 2019
Introduced local char * buffer pointer to avoid casts on output buffer pointer updates
Feb 11 2019
Feb 9 2019
Feb 8 2019
Feb 3 2019
Feb 2 2019
Jan 28 2019
Jan 24 2019
Added ifname parameter to getifflags(), which now uses that instead of the global name var.