Add only a forward declaration of struct pcpu to md_var.h as suggested by markj.

Update commit message.

Updated commit message.

In D54270#1250436, @jrm wrote:

@rosenfeld_grumpf.hope-2000.org, we need to update the commit message to align with https://docs.freebsd.org/en/articles/committers-guide/#commit-log-message. How about this?

libc/stdlib: Port strtonumx() from Illumos #15365

Add strtonumx(), a companion to strtonum(3) that preserves its safety
and error-reporting semantics while allowing the caller to specify a
conversion base, similar to the strtol(3) family of functions.

Reviewed by:    emaste, kib, ziaee
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D54270

Use strtonumx().

Add cpuid.fallback-style option.

Review from Mark

Minor updates.

Rebase.

Allow specification of the target ID for each target.

Improve the comments describing the LUN address parsing.

Rebase.

Rework split_iov() as requested by Corvin.

Rebase.

Reword comment in pci_vtscsi_tmf_handle().

Rebase.

Rebase.

pci_vtscsi_proc()

Clarify comment in pci_vtscsi_init_target().

Rebase.

Rebase.

Rebase.

Rebase, revert unintentional white space change.

Rebase.

Keep in line with original code style.

In D53220#1215995, @corvink wrote:

It would make it easier to review and merge when each point gets it own commit.

I've tested this extensively with VMs running FreeBSD, NetBSD, and OmniOS, each using the same ZFS pool on the same CTL LUNs. This causes a significant speedup of 'zpool scrub' on OmniOS (as in: now twice as fast), while that effect isn't quite as noticable on a FreeBSD VM, it's at least still measurable.

Fix whitespace after cast as requested.

Add copyrights.

Remove an extraneous whitespace in bhyve_merge_cpuid_config().

Improve the commit message.

Remove extra call to bhyve_fixup_cpuid_config(). Improve the commit message.

Remove illumos#16223 from this change.

Make walk_config_nodes non-recursive, leaving recursive processing to
the callback function if needed. Also, stop walking if the callback
returns a non-zero value, returning that value to the caller.

In D51555#1178189, @corvink wrote:

Setting every single cpuid value seems to be a bunch of work for user. Especially, as user have to set every single bit correctly. What's the way forward for this? How will bhyve receive some default cpuid values?

In D51553#1178181, @corvink wrote:

This should be merged into the previous commit D51552 shouldn't it?

Updated commit message.

Do I need a more elaborate commit message here, too?

In D46564#1064476, @corvink wrote:

Where's the commit message?

"-cp" is already illegal, see the check on line 303 and 304, so nothing changes in that regard. Also, "-r cannot be used with -c, -d, -n, or -p" already. I also see no "-h" option, so no "-ch" either, or am I missing anything here?

Add more elaborate commit message. Remove the extra empty line.

Fix manpage as suggested by Corvin.
No longer get the cmd length from the request header as the CRB emulation should pass the correct length instead.

Even FreeBSD's own TPM driver writes the INT_ENABLE register during attach, writing 0 to make sure interrupts are off. bhyve really shouldn't crash the VM when that happens.

Document the swtpm backend in bhyve.8 and bhyve_config.5.