Code looks fine to me, but has the new functions been tested on Azure ? As in local Hyper-V we mostly dont use pci passthrough.

In D39395#899654, @yuripv wrote:

In D39395#899221, @schakrabarti_microsoft.com wrote:

Has this change been tested?

Of course, I used it as I was working on it :)

I didn't add anyone to reviewers though just yet as I am still thinking about the options here:

1. have this in base for a (bit better) resolution with console and scfb
2. have this entirely in drm-kmod (that will be completely separate change) for things like wayland compositors to work
3. have this in base and provide interfaces for drm module to re-use

• Changed the function vmbus_get_dma_tag to create the tag inside.

• Changed the function vmbus_get_dma_tag to create the tag inside.

In D41728#951388, @andrew wrote:

Can you include more context https://wiki.freebsd.org/Phabricator#Create_a_Revision_via_Web_Interface

Updating the diff with arc

I have tested in arm64 and x86 and looks good to me.

In D40227#916382, @schakrabarti_microsoft.com wrote:

If possible please get the change thoroughly tested in Azure x86 platform or Hyper-V x86.

Tested on Hyper-V on ARM64 and it is working. The panic from gic redistributor is not coming.

If possible please get the change thoroughly tested in Azure x86 platform or Hyper-V x86.

I will try to test the patch on Azure x86 gen1 and gen2 and arm64.
I guess by this weekend I can complete it.

hyperv_dmamem_free() is removed, but hyperv_dmamem_alloc() stays, so what about the memory allocated by hyperv_dmamem_alloc()? How they will be freed?
Also it is not very consistent.
We need to do a thorough testing on Azure amd64 gen1 gen2 and arm64 with this patch.
Have you tested the change on Hyper-V x86 and arm64?

In D40227#915806, @andrew wrote:

hyperv_dmamem_alloc is used in amd64 code. I wasn't planning on touching that as I am unable to easily test the change.

Also if hyperv_dmamem_alloc() and hyperv_dmamem_free() is not in use, please remove them from vmbus. As they are dead code.

Has this change been tested?

@tsoome Can you please share the patch, would like to test it on Hyper-V arm64 and x86. Thanks.

In D37763#862942, @imp wrote:

Are there times other than when running as a hyperv guest that these might be needed?

In D36052#857738, @tsoome wrote:

small nits still, but good otherwise, I assume, this code does work as expected now?

In D36052#857698, @tsoome wrote:

In D36052#857682, @schakrabarti_microsoft.com wrote:

Setting other values than default values cause hang during comc_setup. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266248

It seems, you got some extra files included?

Setting other values than default values cause hang during comc_setup. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266248

Will put the

In D36467#834142, @emaste wrote:

It seems that some of the content of these comes from sys/dev/hyperv/vmbus/vmbus.c and other files under vmbus/. Are there corresponding changes to those?

These are the changes for x86 (for both 32 and 64bit).

Addressed review comments.

fixed the review comments for adding arm_smccc_hvc according to the new style.

addressed all the review comments.

Updated loader.mk for the LOADER_AARCH64_HYPERV_SUPPORT.

smccc related changes moved to original smccc files and also addressed styling comments.

Addressed SPDX license and some styling changes.

Fixed the format and fixed comments.

Updated loader.mk for the LOADER_AARCH64_HYPERV_SUPPORT.

Stripping older large diff to smaller chunks. That way it will be easier to review.

fixed the diff

Fixed one comment and header inclusion.

I have removed storvsc changes from here, as it will be reviewed through a separate bug. Also addressed the comments.

In D36052#818681, @gbe wrote:

I was about to test the match to amd64 Hyper-V but a simple "patch -C < .....diff" wasn't successful.

--------------------------
|Index: sys/dev/hyperv/vmbus/amd64/hyperv_machdep.h
|===================================================================
|--- sys/dev/hyperv/vmbus/amd64/hyperv_machdep.h
|+++ sys/dev/hyperv/vmbus/amd64/hyperv_machdep.h
--------------------------
File to patch:

Is there anything special to get this patch applied?