Page MenuHomeFreeBSD

tstruk_gmail.com (Tadeusz Struk)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 28 2019, 9:38 PM (275 w, 2 h)

Recent Activity

Sep 15 2023

tstruk_gmail.com accepted D41347: security/tpm2-abrmd: Enable load of tpm driver with devd rule.
Sep 15 2023, 5:28 PM

Sep 10 2023

tstruk_gmail.com added a comment to D41803: Upgrade tpm2-abrmd to 3.0.0.

Removed PORTREVISION. Thanks for feedback Li-Wen.

Sep 10 2023, 8:30 PM
tstruk_gmail.com added a comment to D41802: Upgrade tpm2-tools to 5.5.

Removed PORTREVISION. Thanks for feedback Li-Wen.

Sep 10 2023, 8:30 PM
tstruk_gmail.com updated the diff for D41803: Upgrade tpm2-abrmd to 3.0.0.
Sep 10 2023, 8:30 PM
tstruk_gmail.com updated the diff for D41802: Upgrade tpm2-tools to 5.5.
Sep 10 2023, 8:29 PM
tstruk_gmail.com added a comment to D41801: Upgrade tpm2-tss to 4.0.1.

Removed PORTREVISION. Thanks for your feedback Li-Wen.

Sep 10 2023, 8:28 PM
tstruk_gmail.com updated the diff for D41801: Upgrade tpm2-tss to 4.0.1.
Sep 10 2023, 8:26 PM
tstruk_gmail.com added a comment to D41347: security/tpm2-abrmd: Enable load of tpm driver with devd rule.

Could you please rebase that on top of version 3.0.0 when that will be merged and resubmit.
D41803
Thanks!

Sep 10 2023, 12:40 AM
tstruk_gmail.com added reviewers for D41803: Upgrade tpm2-abrmd to 3.0.0: ygy, lwhsu.
Sep 10 2023, 12:37 AM
tstruk_gmail.com requested review of D41803: Upgrade tpm2-abrmd to 3.0.0.
Sep 10 2023, 12:36 AM
tstruk_gmail.com requested review of D41802: Upgrade tpm2-tools to 5.5.
Sep 10 2023, 12:35 AM
tstruk_gmail.com requested review of D41801: Upgrade tpm2-tss to 4.0.1.
Sep 10 2023, 12:32 AM
tstruk_gmail.com abandoned D37577: devd.conf: add tpm rule.
Sep 10 2023, 12:17 AM
tstruk_gmail.com accepted D41347: security/tpm2-abrmd: Enable load of tpm driver with devd rule.
Sep 10 2023, 12:16 AM

Aug 17 2023

tstruk_gmail.com added a comment to D41347: security/tpm2-abrmd: Enable load of tpm driver with devd rule.

Looks ok to me.

Aug 17 2023, 10:00 PM

Dec 1 2022

tstruk_gmail.com added a comment to D37577: devd.conf: add tpm rule.

@imp I think it can be done using devfs.rules. I will try that instead of devd.conf.

Dec 1 2022, 5:52 PM
tstruk_gmail.com added a comment to D37577: devd.conf: add tpm rule.
In D37577#854502, @imp wrote:
In D37577#854319, @imp wrote:

Wouldn't stuff like this be better in devfs.conf?

As far as I know devfs works on mount time. I need this to work on kldload time.

It works for any device that's added after mount time. See devfs.conf(5).

Dec 1 2022, 4:47 PM
tstruk_gmail.com added a comment to D37577: devd.conf: add tpm rule.
In D37577#854319, @imp wrote:

Wouldn't stuff like this be better in devfs.conf?

Dec 1 2022, 4:06 PM
tstruk_gmail.com requested review of D37577: devd.conf: add tpm rule.
Dec 1 2022, 1:51 AM

Apr 2 2022

tstruk_gmail.com updated the diff for D34744: tpm2-abrmd updates.
Apr 2 2022, 7:53 PM
tstruk_gmail.com requested review of D34744: tpm2-abrmd updates.
Apr 2 2022, 12:26 AM

Mar 28 2022

tstruk_gmail.com added inline comments to D34462: tpm2-tss.
Mar 28 2022, 3:06 PM

Mar 21 2022

tstruk_gmail.com updated the diff for D34608: tpm2-tools.
Mar 21 2022, 1:00 AM
tstruk_gmail.com added a comment to D34608: tpm2-tools.

@ygy, yes, the diff is updated now.
Thanks

Mar 21 2022, 12:30 AM
tstruk_gmail.com updated the diff for D34608: tpm2-tools.
Mar 21 2022, 12:30 AM

Mar 18 2022

tstruk_gmail.com updated the summary of D34608: tpm2-tools.
Mar 18 2022, 9:13 PM
tstruk_gmail.com updated the summary of D34608: tpm2-tools.
Mar 18 2022, 9:13 PM
tstruk_gmail.com requested review of D34608: tpm2-tools.
Mar 18 2022, 9:12 PM

Mar 9 2022

tstruk_gmail.com added a comment to D34462: tpm2-tss.

@ygy All should be good now. Do you still need a new revision?

Mar 9 2022, 2:32 AM
tstruk_gmail.com added a comment to D34462: tpm2-tss.

Done. @tstruk_gmail.com , please note that you may need to change the email in your personal settings yourself.

Mar 9 2022, 2:30 AM
lwhsu renamed tstruk_gmail.com from tadeusz.struk_intel.com to tstruk_gmail.com.
Mar 9 2022, 1:54 AM

Mar 8 2022

tstruk_gmail.com added a comment to D34462: tpm2-tss.

@ygy @lwhsu the problem is that the account tadeusz.struk_intel.com is registered with my tstruk@gmail.com. As far as I can remember it was setup by @lwhsu.
I can not change it now because it says: "You can not change usernames because you are not an administrator. Only administrators can change usernames."
Could one of you change tadeusz.struk_intel.com to tadeusz.struk or tstruk please?

Mar 8 2022, 3:22 PM
tstruk_gmail.com added a comment to D34462: tpm2-tss.

Hi @ygy
The tstruk@gmail.com is my personal email. The email address @intel.com is no longer valid. I will register a new account and approve the reviews.
Thanks for your feedback

Mar 8 2022, 3:16 PM

Mar 7 2022

tstruk_gmail.com requested review of D34463: tpm2-abrmd.
Mar 7 2022, 1:35 AM
tstruk_gmail.com requested review of D34462: tpm2-tss.
Mar 7 2022, 1:32 AM

Sep 29 2021

tstruk_gmail.com updated the diff for D32214: tpm2-tools.

Generated a new diff against 4.3.1 instead of 4.3.0

Sep 29 2021, 4:55 AM
tstruk_gmail.com added a comment to D32214: tpm2-tools.

Build failed on 11: https://gist.github.com/4f37fbe79be334ce56713fb93f187d52

I would say that if we cannot fix this easily, let's hold off updating this port until 2021Q4 branch and 11-eol tag created.

Sep 29 2021, 4:23 AM
tstruk_gmail.com requested review of D32214: tpm2-tools.
Sep 29 2021, 2:34 AM

May 20 2021

tstruk_gmail.com requested review of D30364: tpm2-tools v4.3.1.
May 20 2021, 5:34 PM

May 18 2021

tstruk_gmail.com requested review of D30326: tpm2-tss v3.1.0.
May 18 2021, 4:13 AM

Mar 4 2021

tstruk_gmail.com requested review of D29053: tpm2-tools v4.3.0.
Mar 4 2021, 4:27 AM
tstruk_gmail.com requested review of D29052: tpm2-abrmd v2.4.0.
Mar 4 2021, 4:25 AM
tstruk_gmail.com requested review of D29051: tpm2-tss v2.4.5.
Mar 4 2021, 4:22 AM

Aug 7 2020

tstruk_gmail.com added a comment to D25981: tpm2-tss v2.4.2.

I committed this with a pkg-plist fix.

Aug 7 2020, 1:47 PM

Aug 6 2020

tstruk_gmail.com added a reviewer for D25981: tpm2-tss v2.4.2: lwhsu.
Aug 6 2020, 11:35 PM
tstruk_gmail.com added a reviewer for D25982: tpm2-tools v4.2.1: lwhsu.
Aug 6 2020, 11:35 PM
tstruk_gmail.com updated the summary of D25982: tpm2-tools v4.2.1.
Aug 6 2020, 11:34 PM
tstruk_gmail.com requested review of D25982: tpm2-tools v4.2.1.
Aug 6 2020, 11:32 PM
tstruk_gmail.com requested review of D25981: tpm2-tss v2.4.2.
Aug 6 2020, 11:31 PM

Jun 23 2020

tstruk_gmail.com requested review of D24934: Update security/tpm2-abrmd/distinfo.
Jun 23 2020, 3:20 AM

May 20 2020

tstruk_gmail.com added a comment to D24934: Update security/tpm2-abrmd/distinfo.

Is it possible to check the difference between the old and new distfiles?

May 20 2020, 9:33 PM

May 18 2020

tstruk_gmail.com requested review of D24905: Update security/tpm2-abrmd to version 2.3.2.
May 18 2020, 8:06 PM
tstruk_gmail.com requested review of D24904: Update security/tpm2-tools to version 4.2.
May 18 2020, 8:06 PM
tstruk_gmail.com requested review of D24903: Update security/tpm2-tss to version 2.4.1.
May 18 2020, 8:06 PM

Sep 23 2019

tstruk_gmail.com added a comment to D21770: security/tpm2-abrmd: update default TCTI config.

I'll commit with minor fixes.

Sep 23 2019, 10:50 PM · Contributor Reviewers (ports)
tstruk_gmail.com created D21770: security/tpm2-abrmd: update default TCTI config.
Sep 23 2019, 6:20 PM · Contributor Reviewers (ports)

Sep 17 2019

tstruk_gmail.com added a comment to D21649: TPM2-TSS.

Sorry, one last thing to confirm, is tstruk@gmail.com also your email address?

Sep 17 2019, 7:27 PM
tstruk_gmail.com added a comment to D21649: TPM2-TSS.

Please let me know if you need me to commit this (and D21650, D21651, D21650).

Sep 17 2019, 3:27 PM

Sep 16 2019

tstruk_gmail.com added a comment to D21650: TPM2-Tools.

Yes it was a flag problem. Now it works on 12.0-Release and 13.0-Current for me. Thanks for reviewing this.

Sep 16 2019, 11:36 PM
tstruk_gmail.com updated the diff for D21650: TPM2-Tools.

Update to use CRYPTO_FLAGS instead of LIBCRYPTO_CLAGS

Sep 16 2019, 11:36 PM
tstruk_gmail.com added inline comments to D21650: TPM2-Tools.
Sep 16 2019, 9:57 PM
tstruk_gmail.com added a comment to D21650: TPM2-Tools.

Still not sure if that's the best solution, but following examples from other ports I marked tools as broken when OSVERSION <= 1200086 and OpenSSL < 1.1.0

Sep 16 2019, 7:26 PM
tstruk_gmail.com updated the diff for D21650: TPM2-Tools.

Mark tools as broken on FreeBSD 12.0 and openSSL < 1.1.0

Sep 16 2019, 7:23 PM

Sep 14 2019

tstruk_gmail.com added a comment to D21650: TPM2-Tools.
In D21650#472076, @tadeusz.struk_intel.com wrote:

This port doesn't build. Please check the log available at https://reviews.freebsd.org/D21650#471935

Is it failing on 12.0-R? It is building fine for me on 13.0-CURRENT and poudriere v3.3.2_1

Yes. Is this port only supposed to work on 13-CURRENT?

Sep 14 2019, 1:59 PM
tstruk_gmail.com updated the diff for D21651: TPM2-ABRMD.

Removed unneeded LIBS+= line

Sep 14 2019, 1:55 PM
tstruk_gmail.com added inline comments to D21651: TPM2-ABRMD.
Sep 14 2019, 1:54 PM
tstruk_gmail.com added a comment to D21650: TPM2-Tools.

This port doesn't build. Please check the log available at https://reviews.freebsd.org/D21650#471935

Sep 14 2019, 1:46 PM
tstruk_gmail.com updated the diff for D21652: Change _tss user to more generic.

Reworked according to feedback

Sep 14 2019, 1:22 AM
tstruk_gmail.com updated the diff for D21651: TPM2-ABRMD.

Reworked according to feedback

Sep 14 2019, 1:21 AM
tstruk_gmail.com updated the diff for D21650: TPM2-Tools.

Reworked according to feedback

Sep 14 2019, 1:20 AM

Sep 13 2019

tstruk_gmail.com created D21652: Change _tss user to more generic.
Sep 13 2019, 10:05 PM
tstruk_gmail.com created D21651: TPM2-ABRMD.
Sep 13 2019, 10:03 PM
tstruk_gmail.com created D21650: TPM2-Tools.
Sep 13 2019, 10:00 PM
tstruk_gmail.com created D21649: TPM2-TSS.
Sep 13 2019, 9:58 PM