Looks okay to me.

Only assign "gop" if the framebuffer type is FB_GOP.

In D53413#1219714, @cperciva wrote:

Does this work with cross-builds? I suspect that WSTAGEDIR is getting set to "" and then you're setting PKG_ABI based on /usr/bin/uname in the host system.

In D52305#1219629, @jhb wrote:

Sorry I missed this earlier. Please merge into 15.0 if possible.

On Sat Oct 11, 2025 at 2:26 AM +0300, Steve Kargl wrote:

I do not have a phabricator account. That method to
review patches came after I stopped committing.

I did look at your patch, and do believe that it
is the correct fix. If you compare to remainderf(),
you'll see that the float version considers the
entire significand. I also checked remainderl().
It calls remquol() and it's implementation is
much different than the float and double versions.

Will do. I tried to add him to the review before uploading the patch but couldn't find an account.

Allocate fifo before locking priv->mtx

malloc priv->events with the correct size