Change Details

This loader tunable is to specify the platform. Well the platform probe function `platform_probe_and_attach()` runs at early boot stage prior to mi_startup(), thus it is pointless but confusing to set it after the probe, i.e. the platform has been chosen. The sysctl flag CTLFLAG_TUN is useless but harmless prior to change [1]. [1] 3da1cf1e88f8 Extend the meaning of the CTLFLAG_TUN flag to ...

Prior to change [1] this flag is useless but harmless. After the change plat_name[] will be fetched from kernel environment after invoking the platform probe function `platform_probe_and_attach()`. The probe function runs at early boot stage prior to `mi_startup()` thus it is too late and pointless to set plat_name[]. Nathan mentioned that the logic to specify the platform pre-dates the powerpc64 work, and is from the original pre-FDT Book-E bringup from like 2008. So it's irrelevant these days. Let's clean it up now. [1] 3da1cf1e88f8 Extend the meaning of the CTLFLAG_TUN flag to ... MFC after: 3 days

This loader tunablePrior to change [1] this flag is to specify the platformuseless but harmless. WellAfter the platform probechange function `platform_probe_and_attach()` runs at early boot stage prior to_name[] will be fetched from kernel environment after invoking the mi_startup(),platform probe function `platform_probe_and_attach()`. thus it is pointless but confusing to set it after the probe,The probe function i.e. the platform has been chosenruns at early boot stage prior to `mi_startup()` thus it is too late and pointless to set plat_name[]. The sysctl flag CTLFLAG_TUN is useless but harmless prior to change [1]Nathan mentioned that the logic to specify the platform pre-dates the powerpc64 work, and is from the original pre-FDT Book-E bringup from like 2008. So it's irrelevant these days. Let's clean it up now. [1] 3da1cf1e88f8 Extend the meaning of the CTLFLAG_TUN flag to ... MFC after: 3 days