Page MenuHomeFreeBSD

ql*_def.h: fix QL_ALIGN parenthesization
ClosedPublic

Authored by rlibby on Oct 14 2017, 7:52 PM.
Tags
None
Referenced Files
F81970956: D12673.diff
Sat, Dec 14, 10:42 PM
Unknown Object (File)
Dec 20 2023, 12:23 AM
Unknown Object (File)
Nov 22 2023, 5:29 PM
Unknown Object (File)
Oct 19 2023, 10:18 PM
Unknown Object (File)
Oct 19 2023, 6:38 PM
Unknown Object (File)
Aug 11 2023, 12:38 AM
Unknown Object (File)
Aug 2 2023, 6:47 AM
Unknown Object (File)
Aug 2 2023, 6:46 AM
Subscribers
None

Details

Summary

QL_ALIGN is a set of copies of roundup2, but it was missing an outer set of parentheses, which began to matter with r324538. Now, fully copy the parenthesization of roundup2.


To add a little more color, I believe r324538 is broken in ql_capture_drvr_state without this. Expression like this

	hdr->rx_state_offset = hdr->tx_state_offset + QL_ALIGN(size, 64);

will yield the wrong result.

The gcc build is also currently broken because of the resulting warning.

Test Plan

buildkernel

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12048
Build 12355: arc lint + arc unit

Event Timeline

Looks good to me. Thanks for the fix.

This revision is now accepted and ready to land.Oct 18 2017, 5:59 PM
This revision was automatically updated to reflect the committed changes.