Page MenuHomeFreeBSD
Differential D13885

ixgbe(4): Update shared code, add support for X552, fix bug
ClosedPublic
Actions

Authored by krzysztof.galazka_intel.com on Jan 12 2018, 4:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 8 2024, 5:51 PM
Unknown Object (File)
Feb 1 2024, 7:57 AM
Unknown Object (File)
Jan 12 2024, 5:53 PM
Unknown Object (File)
Jan 8 2024, 2:32 AM
Unknown Object (File)
Jan 8 2024, 2:29 AM
Unknown Object (File)
Jan 8 2024, 2:29 AM
Unknown Object (File)
Jan 8 2024, 2:29 AM
Unknown Object (File)
Jan 8 2024, 2:29 AM
View All 66 Files
Subscribers
ae
erj
imp
jeffrey.e.pieper_intel.com
piotr.pietruszewski_intel.com
skozlov

Details

Reviewers
sbruno
shurd
kbowling
skozlov
jeffrey.e.pieper_intel.com
Group Reviewers
Intel Networking
Commits
rS331224: ixgbe(4): Update shared code, add support for X552 1G, fix bug
Summary

This patch will:

  • Update ixgbe shared code
  • Add support for Intel(R) Ethernet Connection X552 1000BASE-T
  • Add error handling for link state check preventing VF from stopping traffic after changing PF's MTU value.

History of commits included in this revision may be found at https://github.com/intel-wired-ethernet/freebsd/commits/ixgbe-D13885

Test Plan

Compile-tested with minimal touch-testing. Respectfully request waiting for our Validation Team to perform a test pass before committing.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14534
Build 14673: arc lint + arc unit

Event Timeline

krzysztof.galazka_intel.com created this revision.Jan 12 2018, 4:46 PM
Herald added subscribers: ae, imp. · View Herald TranscriptJan 12 2018, 4:46 PM
krzysztof.galazka_intel.com added a reviewer: kbowling.Jan 12 2018, 4:50 PM
piotr.pietruszewski_intel.com edited the summary of this revision. (Show Details)Jan 15 2018, 2:11 PM
kbowling accepted this revision.Jan 15 2018, 2:21 PM
piotr.pietruszewski_intel.com updated this revision to Diff 37970.Jan 15 2018, 3:00 PM
piotr.pietruszewski_intel.com edited the summary of this revision. (Show Details)
piotr.pietruszewski_intel.com edited the test plan for this revision. (Show Details)
piotr.pietruszewski_intel.com added a subscriber: piotr.pietruszewski_intel.com.
  • Bump version numbers.
sbruno accepted this revision.Jan 16 2018, 1:56 PM

Let me know if you need me to commit this.

This revision is now accepted and ready to land.Jan 16 2018, 1:56 PM
skozlov requested changes to this revision.Jan 16 2018, 4:12 PM
skozlov added a subscriber: skozlov.

Blocking until Intel internal validation is complete.

This revision now requires changes to proceed.Jan 16 2018, 4:12 PM
jeffrey.e.pieper_intel.com requested changes to this revision.Jan 16 2018, 10:39 PM
jeffrey.e.pieper_intel.com added a subscriber: jeffrey.e.pieper_intel.com.

ixv is totally broken. on a FreeBSD host with PCI_IOV, assigning an IP address to a "bare metal" ixv interface{F3125365} causes a kernel panic. On a Linux host, the VF hangs when assigned an IP address and requires a reboot of the VM to recover.

piotr.pietruszewski_intel.com updated this revision to Diff 38085.Jan 17 2018, 1:32 PM
  • Fix kernel panic occuring when IP is assigned to ixv interface

This patch will fix kernel panic occuring when IP address is assigned
to ixv interface on FreeBSD host with PCI_IOV.

Harbormaster completed remote builds in B14433: Diff 38085.Jan 17 2018, 1:32 PM
piotr.pietruszewski_intel.com updated this revision to Diff 38091.Jan 17 2018, 3:54 PM
  • Fix adapter status reporting
Harbormaster completed remote builds in B14438: Diff 38091.Jan 17 2018, 3:54 PM
piotr.pietruszewski_intel.com added a comment.Jan 17 2018, 3:56 PM

The above two patches resolve aforementioned kernel panic issue. Issue with VFs unable to pass traffic on FreeBSD host with PCI_IOV is under investigation.

piotr.pietruszewski_intel.com updated this revision to Diff 38137.Jan 18 2018, 12:05 PM
piotr.pietruszewski_intel.com retitled this revision from ixgbe(4): Update shared code, add support for X552, fix bugs to ixgbe(4): Update shared code, add support for X552, fix bug.
piotr.pietruszewski_intel.com edited the summary of this revision. (Show Details)
  • Revert SRIOV initialization fix

SRIOV initialization fix is reverted at the request of Validation Team due to its incompleteness.

Harbormaster completed remote builds in B14454: Diff 38137.Jan 18 2018, 12:05 PM
krzysztof.galazka_intel.com updated this revision to Diff 38348.Jan 23 2018, 11:47 AM

Rebased on top of HEAD with erj@ patch for ixv_if_init (r328365)

sbruno added a comment.Jan 26 2018, 5:20 PM

Unrelated, is there a use case for FreeBSD Bhyve here? If we had PF support on FreeBSD, could we use pass through to use VFs?

skozlov added a comment.Jan 26 2018, 5:24 PM
In D13885#295301, @sbruno wrote:

Unrelated, is there a use case for FreeBSD Bhyve here? If we had PF support on FreeBSD, could we use pass through to use VFs?

Yes, that'd be possible.

jeffrey.e.pieper_intel.com added a comment.Jan 26 2018, 5:36 PM
In D13885#295301, @sbruno wrote:

Unrelated, is there a use case for FreeBSD Bhyve here? If we had PF support on FreeBSD, could we use pass through to use VFs?

This patch originally was supposed to fix PCI_IOV support, but it introduced regressions. We thought it would be better to remove that portion of the patch until the code is complete and functional.

skozlov accepted this revision.Mar 19 2018, 4:09 PM

The validation exposed a memory leak for a specific traffic pattern. After additional investigation the same leak was found in iflib igb/em driver as well.
As that's the only issue discovered during testing, and, most probably, it's not caused by the changes in the patch - it was decided to merge the patch.

jeffrey.e.pieper_intel.com accepted this revision.Mar 19 2018, 5:30 PM
This revision is now accepted and ready to land.Mar 19 2018, 5:30 PM
erj closed this revision.Mar 19 2018, 10:37 PM
erj added a subscriber: erj.

Committed in rS331224.

(Why do these never get automatically closed when I commit something?)

Revision Contents
Changeset List

PathSize
sys/
dev/
ixgbe/
3 lines
15 lines
3 lines
14 lines
16 lines
6 lines
156 lines
10 lines
22 lines
25 lines
19 lines
48 lines
7 lines
3 lines
128 lines

Diff 38348

View Options

sys/dev/ixgbe/if_ix.c

Loading...
View Options

sys/dev/ixgbe/if_ixv.c

Loading...
View Options

sys/dev/ixgbe/ixgbe_82598.c

Loading...
View Options

sys/dev/ixgbe/ixgbe_82599.c

Loading...
View Options

sys/dev/ixgbe/ixgbe_api.c

Loading...
View Options

sys/dev/ixgbe/ixgbe_common.h

Loading...
View Options

sys/dev/ixgbe/ixgbe_common.c

Loading...
View Options

sys/dev/ixgbe/ixgbe_dcb.c

Loading...
View Options

sys/dev/ixgbe/ixgbe_dcb_82598.c

Loading...
View Options

sys/dev/ixgbe/ixgbe_dcb_82599.c

Loading...
View Options

sys/dev/ixgbe/ixgbe_phy.c

Loading...
View Options

sys/dev/ixgbe/ixgbe_type.h

Loading...
View Options

sys/dev/ixgbe/ixgbe_vf.c

Loading...
View Options

sys/dev/ixgbe/ixgbe_x540.c

Loading...
View Options

sys/dev/ixgbe/ixgbe_x550.c

Loading...