Updates to latest release. This makes some of our patches
unnecessary, since they have gone upstream. Apply some new
hacks to get it to build BLAS and OpenMP.
Details
Details
- It builds on amd64 11.1, i386 10.3
- Needs testing on aarch64
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I think I had some threading issues here when trying to build CMake from git a while ago too. Do you have the exact error message at hand so we could investigate? A quick build of 3.11.0-rc1 on Fedora shows me something like this:
[ 90%] Linking CXX executable ../bin/cmake /usr/bin/ld: libCMakeLib.a(cmQtAutoGeneratorMocUic.cxx.o): undefined reference to symbol 'pthread_create@@GLIBC_2.2.5' //usr/lib64/libpthread.so.0: error adding symbols: DSO missing from command line
but everything works fine with master.
| devel/cmake/Makefile | ||
|---|---|---|
| 22 ↗ | (On Diff #39718) | USES=libarchive was added by bapt in r392537. Was there a specific reason to remove it? Does not removing it fix the threading issues you mentioned? |
Comment Actions
[ 87%] Linking CXX executable ../bin/cmake /usr/bin/ld: undefined reference to symbol `pthread_create@@FBSD_1.0' (try adding -lthr) //lib/libthr.so.3: could not read symbols: Bad value c++: error: linker command failed with exit code 1 (use -v to see invocation)
but everything works fine with master.
It's not about the code, though: the port builds with configure --system-libs, but usually when you build by hand you just run configure. And whatever it's doing then (finding some of the libraries in the system) is getting -pthread into the linker flags, which does the trick as well.
| devel/cmake/Makefile | ||
|---|---|---|
| 22 ↗ | (On Diff #39718) | USES adds a dependency on ports libarchive, while libpkg depends in base libarchive, and I was getting linker warnings that libarchive.so.13 might conflict with libarchive.so.6. I don't think this has anything to do with the threading issues -- I have ports libarchive installed and it is found and used if I don't enable the pkg generator in CPack but the threading issue persists. |
| devel/cmake-doc/pkg-plist | ||
|---|---|---|
| 1 ↗ | (On Diff #39718) | empty line. |
| devel/cmake-doc/pkg-plist | ||
|---|---|---|
| 3 ↗ | (On Diff #39718) | ^ this should not be %%CMAKE_BUILD_TYPE%% but explictely release |
Comment Actions
Update to 3.11.0 final, fix FindBLAS and FindOpenMP; 0 new fallout
failures on a local 11.1 build.
Comment Actions
See recent comments in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227372 for stage-qa problems with this change.