I guess pkg-install and pkg-deinstall could be replaced with these pkg-plist entries

@dir(condor,condor,) /home/condor/execute
@dir(condor,condor,) /home/condor/log
@dir(condor,condor,) /home/condor/spool
@dir(condor,condor,) /home/condor/config
@dir(condor,condor,) /home/condor
@dir /home

and

post-install:
	@${MKDIR} -p ${STAGEDIR}/home/${PORTNAME}
.for dir in execute log spool config
	@${MKDIR} ${STAGEDIR}/home/${PORTNAME}/${dir}
.endfor

I also wonder if /home/condor is the right place? I see you discuss this in the pkg-install comments.

I think that's worth exploring, but I'd rather wait until the next commit rather than potentially introduce a regression under time pressure.

The port is currently marked broken and I'd like to commit a fix ASAP without any unnecessary functional changes, then take some time to test the changes you suggested as part of the WIP port. I would expect to upgrade to the 8.6.x branch in the next month or two anyway.

The changes I've proposed for now only fix the build issue, remove patches that have been incorporated upstream, and tidy up a few cosmetic issues.

Thanks,

JB

I think I copy/pasted that line late in the game, after checking for += lint. Note that I fixed LIB_DEPENDS and CMAKE_ARGS, but then missed this one. I fixed it in the WIP port so it will be corrected in the next commit. Thanks!