Page MenuHomeFreeBSD
Differential D18122

sfxge(4): fix warnings from VS2015 C compiler (C4100)
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 3, 8:41 AM
Unknown Object (File)
Wed, Nov 20, 10:56 AM
Unknown Object (File)
Wed, Nov 20, 10:44 AM
Unknown Object (File)
Jan 11 2024, 9:56 PM
Unknown Object (File)
Dec 23 2023, 1:16 AM
Unknown Object (File)
Nov 24 2023, 3:23 PM
Unknown Object (File)
Apr 22 2023, 3:42 PM
Unknown Object (File)
Mar 3 2023, 11:57 PM
View All 12 Files
Subscribers
imp

Details

Reviewers
gnn
philip
Commits
rS342501: MFC r340888
rS342430: MFC r340888
rS342324: MFC r340888
rS340888: sfxge(4): fix warnings from VS2015 C compiler (C4100)
Summary

Fix multiple level 4 warnings
"C4100: 'xxx': unreferenced formal parameter"
no functional changes.

The _NOTE(ARGUNUSED(xxx)) annotations are being exposed to the Visual
Studio 2015 C compiler with the following:

#define _NOTE_ARGUNUSED(...) UNREFERENCED_PARAMETER((__VA_ARGS__));
#define _NOTE(_annotation)   _NOTE_ ## _annotation

Submitted by: Andrew Lee <alee at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20978
Build 20343: arc lint + arc unit

Event Timeline

arybchik created this revision.Nov 21 2018, 11:25 AM
Harbormaster completed remote builds in B20978: Diff 50719.Nov 21 2018, 11:25 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 24 2018, 4:32 PM
Closed by commit rS340888: sfxge(4): fix warnings from VS2015 C compiler (C4100) (authored by arybchik). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 24 2018, 4:32 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sfxge/
common/
3 lines
2 lines
8 lines
2 lines
6 lines
2 lines

Diff 50719

View Options

sys/dev/sfxge/common/ef10_nvram.c

Loading...
View Options

sys/dev/sfxge/common/ef10_rx.c

Loading...
View Options

sys/dev/sfxge/common/ef10_tx.c

Loading...
View Options

sys/dev/sfxge/common/efx_ev.c

Loading...
View Options

sys/dev/sfxge/common/efx_lic.c

Loading...
View Options

sys/dev/sfxge/common/efx_mcdi.c

Loading...