Differential D19250

www/node: pass LDFLAGS to host and target linker
ClosedPublic
Actions

Authored by bhughes on Feb 19 2019, 7:16 PM.

Details

Reviewers

Commits

rP495723: MFH: r494851 r495525
rP495528: www/node6: set environment variables for host build
rP495527: www/node8:set environment variables for host build
rP495526: www/node10: set environment variables for host build
rP495525: www/node: set environment variables for host build

Summary

The Node.js build system does not use LDFLAGS from the environment; these must be passed as LDFLAGS.host and LDFLAGS.target, as with LINK.*

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 22581
Build 21711: arc lint + arc unit

Event Timeline

bhughes created this revision.Feb 19 2019, 7:16 PM

Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptFeb 19 2019, 7:16 PM

Harbormaster completed remote builds in B22581: Diff 54079.Feb 19 2019, 7:16 PM

bhughes retitled this revision from www/node: pass LDFLAGS to host and target linker The Node.js build system does not use LDFLAGS from the environment; these must be passed as LDFLAGS.host and LDFLAGS.target, as with LINK.* to www/node: pass LDFLAGS to host and target linker.Feb 19 2019, 7:17 PM

bhughes edited the summary of this revision. (Show Details)

bhughes added a reviewer: pkubaj.Feb 19 2019, 7:31 PM

Builds fine on powerpc64.
Also backport it to www/node10 (needs the same treatment).

This revision is now accepted and ready to land.Feb 20 2019, 8:14 AM

Pass C*FLAGS and LDFLAGS to the host build

This revision now requires review to proceed.Feb 27 2019, 5:37 AM

Harbormaster completed remote builds in B22760: Diff 54447.Feb 27 2019, 5:37 AM

The Node.js build system supports cross-compilation via node-gyp, which picks up CC, CXX, LINK, C*FLAGS, and LDFLAGS from the environment for the target build, but not for the host. We only need to set the environment variables for the "host" build in the node ports.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 12 2019, 9:05 PM

Closed by commit rP495525: www/node: set environment variables for host build (authored by bhughes). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

www/

node/

Makefile

6 lines

Diff 54079

View Options

www/node: pass LDFLAGS to host and target linkerClosedPublicActions