Mk/bsd.sanity.mk: Flag nop options helpers set after bsd.port.options.mk
ClosedPublic
Actions

Authored by tobik on Mar 12 2019, 5:21 AM.

Details

Reviewers

None

Group Reviewers

Contributor Reviewers (ports)
O5: Ports Framework
portmgr

Commits

rP499267: Flag nop options helpers that appear after bsd.port.options.mk as DEV_ERRORs

Summary

Just last week lang/harbour (rP494667) and www/igal2 (rP495361)
were broken in that regard. It feels like a big waste of time and
energy to raise these issues post commit. Before I open a PR for
portlint about it, maybe the framework itself can flag this as a
problem instead.

Test Plan

I've run make -V DEV_ERROR over the tree. The following ports
currently have problems:

chinese/fcitx
databases/ldb13
databases/ldb14
databases/percona55-client
databases/percona55-server
databases/py-sqlalchemy10
devel/flang
lang/harbour
mail/mimedefang
net/ng_mikrotik_eoip
net-mgmt/pnp
net-mgmt/pnp-icinga2
www/igal2
www/py-bottle-cork

Maybe false positives due to the port defining a variable that looks
like an options helper. These could trivially be fixed by renaming
the variable:

mail/exim		LMDB_LIBS
mail/exim-ldap2
mail/exim-monitor
mail/exim-mysql
mail/exim-postgresql
mail/exim-sa-exim
mail/exim-sqlite
databases/virtuoso	IODBC_CPPFLAGS

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tobik created this revision.Mar 12 2019, 5:21 AM

Owners added a reviewer: O5: Ports Framework.Mar 12 2019, 5:21 AM

Herald added a reviewer: portmgr. · View Herald TranscriptMar 12 2019, 5:21 AM

Herald added a subscriber: mat. · View Herald Transcript

Harbormaster completed remote builds in B23027: Diff 54960.Mar 12 2019, 5:21 AM

mat added inline comments.Mar 12 2019, 8:18 PM

Mk/bsd.sanity.mk
291–297 ↗	(On Diff #54960)	Could you indent the `.for`/`.if`?

Indent the loop in bsd.sanity.mk too

Harbormaster completed remote builds in B23053: Diff 55007.Mar 13 2019, 4:32 AM

tobik marked an inline comment as done.Mar 13 2019, 4:33 AM

This looks good, let me just have a closer look at it this week.

tobik mentioned this in rP495760: www/igal2: Fix EXIF option.Mar 15 2019, 4:41 AM

tobik mentioned this in rP495761: www/py-bottle-cork: Fix options.

tobik mentioned this in rP495762: net/ng_mikrotik_eoip: Fix PTABLE option.Mar 15 2019, 4:44 AM

tobik mentioned this in rP495763: net-mgmt/pnp: Fix PDF option.Mar 15 2019, 4:50 AM

tobik mentioned this in rP495764: mail/mimedefang: Fix CLAMAV option.Mar 15 2019, 5:02 AM

tobik mentioned this in rP495766: chinese/fcitx: Remove nop options helper.Mar 15 2019, 5:19 AM

tobik mentioned this in rP495774: databases/virtuoso: Replace IODBC_CPPFLAGS and append directly to CPPFLAGS.Mar 15 2019, 8:33 AM

tobik mentioned this in rP495775: devel/flang: Attempt to fix TESTS option.Mar 15 2019, 8:43 AM

tobik mentioned this in rP495779: databases/percona55-server: Attempt to fix OPENSSL option after r446475.Mar 15 2019, 9:05 AM

In D19553#418840, @mat wrote:

This looks good, let me just have a closer look at it this week.

Did you find any problems with it?

tobik mentioned this in rP497938: databases/py-sqlalchemy10: Drop nop MYSQL option.Apr 5 2019, 6:28 AM

tobik mentioned this in rP497939: databases/ldb1{3,4}: Drop nop options helpers.Apr 5 2019, 6:32 AM

tobik abandoned this revision.Apr 15 2019, 4:00 PM

Sorry about not getting back to you sooner. This looks good, only, please, move the bsd.sanity.mk bits before the UNSUPPORTED/DEPRECATED/... things at the end, with all the .if that exist before.

Not sure if I understand correctly where to put it. Let me reclaim and update this.