Details
- Reviewers
wblock oliver - Group Reviewers
Doc Committers
Diff Detail
- Repository
- rD FreeBSD doc repository - subversion
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
2 things I've found...
en_US.ISO8859-1/articles/committers-guide/article.xml | ||
---|---|---|
4013 | I would add a sentence stop at the comma here. Otherwise, this whole paragraph consists of only one long sentence. Instead, it would read like this: It is also possible to specify a date. In that case ... last true commit. Don't forget to add an extra space after the sentence stop. | |
4021–4024 | If I remember my school english correctly, there is something missing here (*looks to native speakers for help*). I think it should say: If some files have been added, or were removed during ... |
I don't want to judge about the grammar as I'm not a native speaker, but what the change tries to say is what I was misunderstood when I struggled while resurrecting a port in the first place.
en_US.ISO8859-1/articles/committers-guide/article.xml | ||
---|---|---|
4013 | The use of "Perform whatever" is a little weird. How about: Make the changes necessary to get the port working again. | |
4015 | The meaning of "last true commit" is kind of unclear. | |
4015 | Needs a comma at the pause, and avoid using "you": distfiles are no longer available, either volunteer to host the distfiles, or find someone | |
4024 | "appropriately" must be interpreted by the reader. It would be helpful to expand on that, like "to make sure the source control tracking of those files is corrected." (There's probably a better way to say that.) | |
4648 | End the question with a question mark. | |
4659 | This should be "for doing so", but is not really needed: merged, and respond with the proper procedure. | |
4663 | No comma after "number". | |
4666 | This can be reworded into a smoother sentence with less pauses: A script is provided to automate merging a specific commit: | |
4668 | Passive->Active: s/It can be/It is/ |