devel/py-botocore: Update to 1.12.142
ClosedPublic
Actions

Authored by koobs on May 5 2019, 11:20 AM.

Details

Reviewers

bhughes

Commits

rP500879: devel/py-botocore: Update to 1.12.142

Summary

www/py-boto3 update requires botocore >= 1.12.142

devel/py-botocore: Update to 1.12.142

 - Update RUN_DEPENDS to match setup.py versions
 - Document RUN_DEPENDS max versions to ease future QA

Reviewed_by: bhughes
Approved by: bhughes (maintainer)
Differential_Revision: D20161

Test Plan

portlint: OK (looks fine.)
testport: OK (poudriere: 12amd64py{36,27})
maketest: Ran 5989 tests in 785.902s OK (SKIP=7)

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

koobs created this revision.May 5 2019, 11:20 AM

Herald added a subscriber: mat. · View Herald TranscriptMay 5 2019, 11:20 AM

Harbormaster completed remote builds in B24112: Diff 57061.May 5 2019, 11:20 AM

koobs edited the summary of this revision. (Show Details)May 5 2019, 11:24 AM

koobs edited the summary of this revision. (Show Details)

LGTM :)

This revision is now accepted and ready to land.May 5 2019, 6:33 PM

Closed by commit rP500879: devel/py-botocore: Update to 1.12.142 (authored by koobs). · Explain WhyMay 6 2019, 2:00 AM

This revision was automatically updated to reflect the committed changes.

koobs mentioned this in rP500879: devel/py-botocore: Update to 1.12.142.

mat added inline comments.May 7 2019, 8:22 AM

head/devel/py-botocore/Makefile
16–19	This change is awful and should be reverted. Adding version requirements in comment is completely useless, especially as they can be expressed just fine in the dependency line: ${PYTHON_PKGNAMEPREFIX}dateutil>=2.1<3.0.0:devel/py-dateutil@${PY_FLAVOR}

What, multiple version specs (AND'd, not OR'd) are supported? If so, WOW.

I've recently been specifying max pinned versions to make future QA easier (grepping the tree), as it is a ridiculously laborious task to do manually, particularly for python ports with a large set of dependencies

In D20161#434772, @koobs wrote:

What, multiple version specs (AND'd, not OR'd) are supported? If so, WOW.

I've recently been specifying max pinned versions to make future QA easier (grepping the tree), as it is a ridiculously laborious task to do manually, particularly for python ports with a large set of dependencies

If it is supported, can we make them support comma separation?

It has been supported ever since we switched to pkg years ago.

And sure I understand what you are saying about commas, but no, we're not changing how it works.

Under the hood, it runs pkg info, you can test for yourself, like, pkg info 'perl5<5.29>5.28'. Empiric testing, pkg info 'perl5<5.29,>5.28' says that this also works, if this is what you meant by commas.