Page MenuHomeFreeBSD
Differential D21370

Add conv=fsync flag to dd
ClosedPublic
Actions

Authored by freqlabs on Aug 22 2019, 7:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 4:50 AM
Unknown Object (File)
Dec 22 2023, 10:57 PM
Unknown Object (File)
Dec 14 2023, 6:51 PM
Unknown Object (File)
Dec 2 2023, 1:33 AM
Unknown Object (File)
Nov 19 2023, 2:13 PM
Unknown Object (File)
Nov 5 2023, 5:15 PM
Unknown Object (File)
Oct 4 2023, 4:13 PM
Unknown Object (File)
Sep 30 2023, 4:13 PM
View All 20 Files
Subscribers
imp
jilles

Details

Reviewers
mmacy
jilles
imp
Group Reviewers
manpages
Summary

The fsync flag performs an fsync(2) on the output file before closing it. This will be useful for the ZFS test suite.

Sponsored by: iXsystems, Inc.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

freqlabs created this revision.Aug 22 2019, 7:07 PM
Herald added a reviewer: manpages. · View Herald TranscriptAug 22 2019, 7:07 PM
Herald added a subscriber: imp. · View Herald Transcript
freqlabs added a comment.Aug 22 2019, 7:08 PM

I am planning a followup to add the fdatasync flag, as well.

freqlabs edited the summary of this revision. (Show Details)Aug 22 2019, 7:09 PM
jilles accepted this revision as: jilles.Aug 22 2019, 8:36 PM
jilles added a subscriber: jilles.

Looks good to me.

bin/dd/dd.h
104

This uses up the last free bit, but that should be OK.

This revision is now accepted and ready to land.Aug 22 2019, 8:36 PM
freqlabs added a child revision: D21373: Add conv=fdatasync flag to dd.Aug 22 2019, 8:47 PM
imp accepted this revision.Aug 28 2019, 7:34 PM
imp added inline comments.
bin/dd/dd.c
513

do you also need to check close(2) calls?

freqlabs added inline comments.Aug 28 2019, 7:48 PM
bin/dd/dd.c
513

It's in the stack: https://reviews.freebsd.org/D21376

freqlabs closed this revision.Sep 3 2019, 6:40 PM

Committed as rS351770

Revision Contents
Changeset List

PathSize
bin/
dd/
1 line
1 line
4 lines
7 lines

Diff 61128

View Options

bin/dd/args.c

Loading...
View Options

bin/dd/dd.h

Loading...
View Options

bin/dd/dd.1

Loading...
View Options

bin/dd/dd.c

Loading...