Ref: https://bugs.freebsd.org/241562

I’m not sure it’s a good idea to default no-strip all tests. It likely fixes my test in particular, but my test could add STRIP= in isolation.

Have you quantified the installed size difference? Maybe I’m imagining we have more tests than we really do. If it’s minimal I’m happy to concede that the point is moot. Also, if make_debug_files is default yes, maybe stripping beyond those sections saves relatively little size per test program.

In D22173#484780, @cem wrote:

I’m not sure it’s a good idea to default no-strip all tests. It likely fixes my test in particular, but my test could add STRIP= in isolation.

Me either so I opened a review for this one line patch for having further discussions. Perhaps we can add STRIP= to this this case first and then discuss the global setting.

Have you quantified the installed size difference? Maybe I’m imagining we have more tests than we really do. If it’s minimal I’m happy to concede that the point is moot. Also, if make_debug_files is default yes, maybe stripping beyond those sections saves relatively little size per test program.

Not yet, but it may make sense to do a check. One (weak) rationale of the size probably doesn't really matter is the the test files are packaged separated in tests.tgz so it won't affect most production installations. While having these default on can help debugging a lot when we encounter a filing case, i.e., we have everything needed in the test VM and the developer doesn't have to build the debug version again. @bapt found stripped test files are not really useful when dealing with https://bugs.freebsd.org/240683 .

Another thought is we can separate symbol files to tests-dbg.txz like base and kern.

In D22173#484781, @lwhsu wrote:

Perhaps we can add STRIP= to this this case first and then discuss the global setting.

Yes, no objection to that. I will go ahead, if you haven't already :-).

Have you quantified the installed size difference? Maybe I’m imagining we have more tests than we really do. If it’s minimal I’m happy to concede that the point is moot. Also, if make_debug_files is default yes, maybe stripping beyond those sections saves relatively little size per test program.

Not yet, but it may make sense to do a check.

I'd like that.

One (weak) rationale of the size probably doesn't really matter is the the test files are packaged separated in tests.tgz so it won't affect most production installations.

Sure, but it impacts all developers (and development VM size requirements) and anyone else installing 'world' from sources without explicitly setting MK_TEST=no.

While having these default on can help debugging a lot when we encounter a filing case, i.e., we have everything needed in the test VM and the developer doesn't have to build the debug version again. @bapt found stripped test files are not really useful when dealing with https://bugs.freebsd.org/240683 .

Another thought is we can separate symbol files to tests-dbg.txz like base and kern.

Yes, I think separate symbol files is a good idea in general.

I did a simple tests, for r354252: without the patch: ${OBJDIR}/release/dist/tests/usr/tests is 106M, with the patch, it becomes 123M.
tests.txz is 12M and 12M.

BTW we do have ${OBJDIR}/dist/tests/usr/lib/debug so it's good to have tests-dbg.txz anyway.

In D22173#485712, @lwhsu wrote:

BTW we do have ${OBJDIR}/dist/tests/usr/lib/debug so it's good to have tests-dbg.txz anyway.

D22272