powerpc: Add a CPU-custom machine check handler
ClosedPublic
Actions

Authored by jhibbits on Feb 17 2020, 7:04 PM.

Details

Reviewers

nwhitehorn
bdragon

Group Reviewers

PowerPC

Commits

rS360881: powerpc: Add a CPU-custom machine check handler

Summary

Some machine checks are process-recoverable, others are not. Let a
CPU-specific handler decide what to do.

This works around a machine check error hit while building www/firefox
and mail/thunderbird, which would otherwise cause the build to fail.

This is only preliminary, soliticing input. There is more work to be
done for the AIM side, as well as implementing the Book-E side.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhibbits created this revision.Feb 17 2020, 7:04 PM

Harbormaster completed remote builds in B29451: Diff 68465.Feb 17 2020, 7:04 PM

bdragon added inline comments.Feb 17 2020, 7:20 PM

sys/powerpc/aim/aim_machdep.c
520 ↗	(On Diff #68465)	Should this have a : "memory"?

jhibbits added inline comments.Feb 17 2020, 7:43 PM

sys/powerpc/aim/aim_machdep.c
520 ↗	(On Diff #68465)	Maybe. This is an obviously incomplete flush, anyway. The correct thing to do here is to flush the full TLB, not just the one entry.

Update diff, to make it build for Book-E as well.

Harbormaster completed remote builds in B30155: Diff 69960.Mar 28 2020, 9:36 PM

Might as well merge the spr.h changes anyway, independent of the rest of this patch.

Do we know all supported 32-bit AIM CPUs do the same things with DSISR? Otherwise, it looks good to me.

In D23731#545586, @nwhitehorn wrote:

Do we know all supported 32-bit AIM CPUs do the same things with DSISR? Otherwise, it looks good to me.

The MPC745x "normally" clears bit 10 of SRR1 at machine check, so this should read 0, but is used for debug; I can put a guard on that if it becomes a problem. The PPC970MP behaves like the POWER9 in this instance. I haven't checked the MPC75x, the only other 32-bit AIM CPU we may run on.

This revision was not accepted when it landed; it landed in state Needs Review.May 10 2020, 7:01 PM

Closed by commit rS360881: powerpc: Add a CPU-custom machine check handler (authored by jhibbits). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhibbits added a commit: rS360881: powerpc: Add a CPU-custom machine check handler.

Herald added a subscriber: imp. · View Herald TranscriptMay 10 2020, 7:01 PM

bdragon mentioned this in D19516: powerpc64: Implement Radix MMU for POWER9 CPUs.May 11 2020, 1:50 AM