See inline comment.

install-strip is not a valid target, rust doesn't use the autotools.

23:22 <@kwm> jbeich: dumbell is working on a rust update
23:23 <@kwm> jbeich: https://reviews.freebsd.org/D2466
23:25 < brd\> will@ has one that he is about to commit too :(
23:27 <@kwm> brd\: oh, hmm. maybe merge the two?
23:32 < brd\> kwm: yeah, talking to him
23:33 < brd\> kwm: combined it is better :)

My version of this patch (before I knew anyone else was looking) has a few extra changes:

• Use REINPLACE_CMD instead of patching curl/wget & forced-clang in configure. This is (still) required to pass poudriere builds.
• Run the unit test suite, i.e. "gmake check".
• Enable & ship the docs -- I determined that they only add a few % extra size, so they should at least be supported via PORTDOCS.
• Set VERBOSE=1 unconditionally; its behavior is more like how FreeBSD usually builds things.

I also have a version of the port for the nightly builds (as lang/rust-devel). Given the pace of Rust's development, I think this port offers developers access to its newer features, although it would require updating more frequently.

My version does not have:

• The manifest manipulation: would be nice if it was documented why this is necessary. Is this to account for removing files related to Rust's separate installer? Why bother? Is there a real concern someone might try to use the Rust install scripts?

That said, given that this update didn't hit ports before 1.0 shipped, we should rebase to 1.0 now. Anybody working on that?

In D2466#47594, @will wrote:

My version of this patch (before I knew anyone else was looking) has a few extra changes:

• Use REINPLACE_CMD instead of patching curl/wget & forced-clang in configure. This is (still) required to pass poudriere builds.

Why are they required? What's the difference between Poudriere and a plain FreeBSD?

• Run the unit test suite, i.e. "gmake check".
• Enable & ship the docs -- I determined that they only add a few % extra size, so they should at least be supported via PORTDOCS.

Both points are nice!

• Set VERBOSE=1 unconditionally; its behavior is more like how FreeBSD usually builds things.

I'm fine with that.

I also have a version of the port for the nightly builds (as lang/rust-devel). Given the pace of Rust's development, I think this port offers developers access to its newer features, although it would require updating more frequently.

I agree.

My version does not have:

• The manifest manipulation: would be nice if it was documented why this is necessary. Is this to account for removing files related to Rust's separate installer? Why bother? Is there a real concern someone might try to use the Rust install scripts?

I did it to be as close as possible to the official Rust standalone installer and in case, developers expect to find this manifest.

That said, given that this update didn't hit ports before 1.0 shipped, we should rebase to 1.0 now. Anybody working on that?

Not me.

However, I worked on a port for Cargo (also ready, just waiting for this change or yours to land before pushing it to Phabricator).

In D2466#47742, @dumbbell wrote:

Why are they required? What's the difference between Poudriere and a plain FreeBSD?

Because in poudriere, packages are built in a clean environment. Your "plain FreeBSD" machine presumably has wget or curl already installed, hence not failing. If you committed this change without accounting for a clean environment, the FreeBSD.org package builders (which use poudriere) would fail the build.

I did it to be as close as possible to the official Rust standalone installer and in case, developers expect to find this manifest.

Ok, fair enough.

That said, given that this update didn't hit ports before 1.0 shipped, we should rebase to 1.0 now. Anybody working on that?

Not me.

However, I worked on a port for Cargo (also ready, just waiting for this change or yours to land before pushing it to Phabricator).

Ok, I'm working on an update for 1.0.

And @riggs committed a third version of the update in rP386722 :-)

I think several changes you and I made are still relevant.

In version 1.0.0 source was restricted to owner rwx which means
only root can install. I had to prepend the following here

post-extract:
(cd ${WRKSRC}; \
	find . -type d -exec chmod 0755 {} \;)

which only covers directories