See architecture
- mesa-dri can be used together with nvidia-driver
- Consumers can depend on the latest GLX/EGL headers
- Less rebuilds due to changes in dependencies
Details
Details
- Reviewers
danfe val_packett.cool zeising kbowling - Group Reviewers
x11 portmgr - Commits
- R11:b44acc9409bd: graphics/mesa-libs: enable libglvnd support
- i915kms on Skylake GT2 (0x1912)
- Firefox (on 11.3 i386) works fine with Sway+Xwayland (on 13.0 amd64)
- nvidia-driver doesn't break Wayland via GBM
- exp-run progress is in bug 246767
Diff Detail
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
There are a very large number of changes, so older changes are hidden. Show Older Changes
Comment Actions
Hi!
This review requires some work to get going, and in our opinion we must get it right, since breaking this will break the whole graphics stack.
Apart from the comments inline in the review, we also need to figure out how to handle mesa. Currently, the patch adds a build dependency in mesa-libs on libglvnd, and other ports depend on libglvnd through Uses/gl.mk. However, libglvnd will need mesa (or another OpenGL provider) to be installed. With the suggested patch this is only pulled in by accident by the dependency on libgbm.so in a few ports. This means that simple installs might not have all the packages needed to work. This needs to be fixed, most likely by an explicit runtime dependency on mesa in libglvnd, or through Uses/gl.mk. This will mean that users of nVidia drivers will have two OpenGL implementations, but that is already the case today. If/when the ports tree gains a requires/provides, this can be revisited.
Over all, there are several things that need to be fixed in order for this to be accepted, and it has to be thoroughly tested as well, since it is a very large change to how the graphics stack is working.
| graphics/libglvnd/Makefile | ||
|---|---|---|
| 5 | Since libglvnd will be an integral part to the graphics stack, we feel that it should be maintained by x11@. This ensures that updates and releases can be coordinated to try to avoid breakage. This also ensures that any issues and PRs will be easily noticed since they are also sent to the mailing list. | |
| 14–17 | What is the reason behind using a git commit hash instead of a release tarball for libglvnd? | |
| graphics/mesa-libs/pkg-plist | ||
| 28–40 | Can you explain what is happening with the various libraries in mesa? I can see that libEGL is renamed to libEGL_mesa, but for instance libGLESv2 and libGL seems to be removed completely from the port. Are they simply replaced by libGLX_mesa, and libglvnd understands this, or is this an oversight? | |
Comment Actions
No difference from mesa-libs. xorg-server and wlroots still depend on mesa-dri and mesa-dri depends on mesa-libs (via libglapi).
Why one would want mesa-libs but not mesa-dri?
This will mean that users of nVidia drivers will have two OpenGL implementations
Assuming NVIDIA users don't want mesa-dri is a mistake. Barring bugs in kernel drivers it should be possible to use Intel/AMD and NVIDIA at the same time e.g., with multiple displays or one display connected to multiple GPUs.
Over all, there are several things that need to be fixed in order for this to be accepted,
What are these? I agree with maintainership, the rest is misunderstanding.
| graphics/libglvnd/Makefile | ||
|---|---|---|
| 5 | Sure. @greg_unrelenting.technology, do you object? | |
| 14–17 | GL_COMMIT is currently mandatory for USE_GITLAB ports. | |
Comment Actions
- graphics/libglvnd: change maintainer to x11@
- x11-servers/xwayland-devel: document a quirk: still better than before when one had to override libmap.conf
| graphics/mesa-libs/pkg-plist | ||
|---|---|---|
| 28–40 | GLX and EGL dispatch are a bit different. I've linked libglvnd architecture in the summary. libGLX_indirect is documented as code comment instead.
| |
Comment Actions
Hi!
After discussing this on the Graphics Team meeting today we all agreed that since this is a big update, and we are getting close to both the 11.4 release and the new quarterly ports branch, this has to wait until after the ports tree branch.
This does not mean this is an approval to commit this after the branch, but gives you a timeline of when at the earliest it can go in.
Comment Actions
Based on the amount of QA required, big would be Xorg update, medium would be Mesa update and small are libglvnd, libX11, libwayland, etc. libglvnd offloads updates risk due to API changes away from Mesa. For example, Mesa has Intel/AMD, X11/Wayland/Vulkan and drm-kmod (legacy, 4.1[16], 5.*) but in Xorg has CSM/UEFI, UMS/KMS, non-x86, many DDX, nvidia-driver versions, legacy/devd/libinput, slave/consumer ports.
In short, as you go up the graphics stack the implicit QA via consumers diminishes.
getting close to both the 11.4 release
11.4 packages use rP536699 instead of /quarterly but updates use /quarterly which is a moving target (i.e., can be fixed/reverted).
and the new quarterly ports branch
Makes sense given only 1 month is left while exp-run hasn't even started (antoine@ doesn't scale).
This does not mean this is an approval to commit this after the branch, but gives you a timeline of when at the earliest it can go in.
Review/test in advance then (EDIT: during the waiting period). I can't respect maintainer which doesn't respect me.
/quarterly only spans 3 months, so dragging the first one or two would repeat the situation.
Comment Actions
So, is there any chance of this being done before one year anniversary of the patch? Libglvnd is a prerequisite for (real) Optimus support, among other things.
Comment Actions
Yeah I agree with @jbeich this is a straight forward patch in the grand scheme of this software stack, so I'll merge it with maintainer timeout to fortify the secondary driver work mentioned above.
Comment Actions
@jbeich this should have gone in first, I was just doing the needful because portmgr had blessed the secondary driver work and it was still sitting unhandled. I am in progress on my own QA on the combination of this on top of that at the moment.