Page MenuHomeFreeBSD
Differential D28768

zfs: Remove unused abd_alloc_scatter_offset_chunkcnt
AbandonedPublic
Actions

Authored by rlibby on Feb 18 2021, 7:37 AM.
Tags
None
Referenced Files
F81890417: D28768.id84183.diff
Thu, Nov 28, 11:53 PM
F81890416: D28768.id84183.diff
Thu, Nov 28, 11:53 PM
F81890415: D28768.id84183.diff
Thu, Nov 28, 11:53 PM
F81890414: D28768.id84183.diff
Thu, Nov 28, 11:53 PM
Unknown Object (File)
Sun, Nov 24, 4:09 AM
Unknown Object (File)
Tue, Nov 12, 10:43 AM
Unknown Object (File)
Sun, Nov 10, 5:57 AM
Unknown Object (File)
Sat, Nov 9, 5:17 AM
View All 21 Files
Subscribers
delphij
imp
jhb
mm

Details

Reviewers
freqlabs
mm
Summary

From openzfs-master bf156c966 commit message:

Remove function that become unused after refactoring in
e2af2acce3436acdb2b35fdc7c9de1a30ea85514.

Cherry-picked from openzfs bf156c966bd68aef3b08716f9e81238a4571236a
Patch Author: Ryan Libby <rlibby@FreeBSD.org>

I posted this review to make sure this is okay in terms of process and commit log. This is a diff & patch, and the above is the intended commit message. I used recent commits by @mm as a template, but I see a few different styles in recent history in git log sys/contrib. This is the upstream commit:
https://github.com/openzfs/zfs/commit/bf156c966bd68aef3b08716f9e81238a4571236a

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 37152
Build 34041: arc lint + arc unit

Event Timeline

rlibby created this revision.Feb 18 2021, 7:37 AM
Herald added a subscriber: delphij. · View Herald TranscriptFeb 18 2021, 7:37 AM
rlibby requested review of this revision.Feb 18 2021, 7:37 AM
Harbormaster completed remote builds in B37152: Diff 84183.Feb 18 2021, 7:38 AM
mm requested changes to this revision.Feb 18 2021, 9:31 AM

I have updated the vendor branch to bf156c966, so technically we can merge from it. The idea is that we keep as low diff to upstream as possible. Have you already done merging from a vendor branch?

This revision now requires changes to proceed.Feb 18 2021, 9:31 AM
mm added a comment.Feb 18 2021, 2:59 PM

I have merged lastest OpenZFS to main including the new "compatibility" property, you can close this now. Thanks for getting the change upstream!

rlibby abandoned this revision.Feb 18 2021, 5:10 PM
In D28768#644214, @mm wrote:

I have merged lastest OpenZFS to main including the new "compatibility" property, you can close this now. Thanks for getting the change upstream!

Great, thanks!

In D28768#644120, @mm wrote:

I have updated the vendor branch to bf156c966, so technically we can merge from it. The idea is that we keep as low diff to upstream as possible. Have you already done merging from a vendor branch?

I have not. I'll keep this in mind for future changes.

Revision Contents
Changeset List

PathSize
sys/
contrib/
openzfs/
module/
os/
freebsd/
zfs/
19 lines

Diff 84183

View Options

sys/contrib/openzfs/module/os/freebsd/zfs/abd_os.c

Loading...