xen/netfront: introduce xen_pv_nics_disabled()
ClosedPublic
Actions

Authored by ehem_freebsd_m5p.com on Mar 23 2021, 10:06 PM.

Details

Reviewers

royger
mhorne

Commits

rG5f7000832791: xen/netfront: introduce xen_pv_nics_disabled()

Summary

ARM guest is considered as HVM in Freebsd but they only support PV nics
(no emulation available).

Submitted by: Elliott Mitchell <ehem+freebsd@m5p.com>
Original implementation: Julien Grall <julien@xen.org>, 2015-10-16 11:26:35

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ehem_freebsd_m5p.com created this revision.Mar 23 2021, 10:06 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 23 2021, 10:06 PM

ehem_freebsd_m5p.com requested review of this revision.Mar 23 2021, 10:06 PM

Harbormaster completed remote builds in B38034: Diff 86228.Mar 23 2021, 10:06 PM

royger accepted this revision.Mar 25 2021, 3:09 PM

This revision is now accepted and ready to land.Mar 25 2021, 3:09 PM

This has the issue brought up in D29351, should sys/arm64/include/xen/xen-os.h be created in one commit and the ARM version of this function be brought in here instead of with the aarch64 jumbo commit?

ehem_freebsd_m5p.com added a subscriber: julien_xen.org.Mar 30 2021, 6:44 PM

ehem_freebsd_m5p.com mentioned this in D29498: xen/arm64: introduce sys/arm64/include/xen/xen-os.h.Mar 30 2021, 7:09 PM

ehem_freebsd_m5p.com added a parent revision: D29811: xen/xen-os: move inclusion of machine/xen-os.h later.Apr 17 2021, 5:45 PM

ehem_freebsd_m5p.com added a child revision: D30950: xen/arm64: enable arm64 Xen configuration.Jun 30 2021, 1:28 AM

ehem_freebsd_m5p.com added a child revision: D29498: xen/arm64: introduce sys/arm64/include/xen/xen-os.h.Jul 3 2021, 12:40 AM

ehem_freebsd_m5p.com removed a child revision: D30950: xen/arm64: enable arm64 Xen configuration.

ehem_freebsd_m5p.com added a child revision: D29403: xen: introduce xen_pv_disks_disabled().Jul 3 2021, 5:54 AM

royger added inline comments.Jul 28 2021, 1:20 PM

sys/x86/include/xen/xen-os.h
50	After PVHv1 removal every supported guest is HVM, so we can remove the check (will do that on a different commit), and get away with the HVM vs PV difference in the code.