Page MenuHomeFreeBSD
Differential D29657

bhyve: add SMBIOS Baseboard Information
ClosedPublic
Actions

Authored by chuck on Apr 8 2021, 7:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 6:10 PM
Unknown Object (File)
Tue, Nov 12, 6:07 PM
Unknown Object (File)
Tue, Nov 12, 3:20 PM
Unknown Object (File)
Mon, Nov 11, 6:54 AM
Unknown Object (File)
Mon, Nov 11, 5:51 AM
Unknown Object (File)
Thu, Nov 7, 3:50 PM
Unknown Object (File)
Thu, Nov 7, 2:29 PM
Unknown Object (File)
Thu, Nov 7, 12:29 PM
View All 33 Files
Subscribers
bcran
imp
lwhsu
rgrimes

Details

Reviewers
grehan
jhb
rgrimes
bcran
Group Reviewers
bhyve
Commits
rG0c6282e842b3: bhyve: add SMBIOS Baseboard Information
Summary

Add the System Management BIOS Baseboard (or Module) Information
a.k.a. Type 2 structure to the SMBIOS emulation.

Test Plan

Run dmidecode -t 2 and verify output
Also tested against a Linux appliance image with a buggy kernel drive which assumes these values exist

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chuck created this revision.Apr 8 2021, 7:18 PM
Herald added a reviewer: bhyve. · View Herald TranscriptApr 8 2021, 7:18 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript
Harbormaster completed remote builds in B38426: Diff 87064.Apr 8 2021, 7:18 PM
chuck requested review of this revision.Apr 8 2021, 7:18 PM
chuck edited the test plan for this revision. (Show Details)Apr 8 2021, 7:19 PM
rgrimes accepted this revision as: rgrimes.Apr 9 2021, 4:47 AM
This revision is now accepted and ready to land.Apr 9 2021, 4:47 AM
grehan accepted this revision.Apr 9 2021, 9:17 AM

Looks good.

Running the smbiosview command from the EFI shell prompt (non type-2 tables excluded:

Shell> smbiosview
...
=========================================================
Type=2, Handle=0x3
Dump Structure as:
Index=2,Length=0x31,Addr=0x3FBCB077
00000000: 02 0F 03 00 01 02 03 04-05 01 06 03 00 0A 00 46  *...............F*
00000010: 72 65 65 42 53 44 00 42-48 59 56 45 00 31 2E 30  *reeBSD.BHYVE.1.0*
00000020: 00 4E 6F 6E 65 00 4E 6F-6E 65 00 4E 6F 6E 65 00  *.None.None.None.*
00000030: 00                                               *.*
Structure Type: Base Board Information
Format part Len : 15
Structure Handle: 3
Manufacturer: FreeBSD
ProductName: BHYVE
Version: 1.0
SerialNumber: None
AssetTag: None
Base Board Feature Flags: Hosting board
LocationInChassis: None
ChassisHandle: 0x3
Base Board Board Type: Motherboard
bcran accepted this revision.Apr 9 2021, 4:38 PM

Just a comment typo: "number of contained objecct handles" - should be "object".

bcran added a comment.Apr 9 2021, 4:41 PM

I noticed this is against the svn repo:

Repository rS FreeBSD src repository - subversion"

You'll probably want to switch over to Git and rebase this patch.

chuck added a comment.Apr 11 2021, 2:30 PM
In D29657#665474, @bcran wrote:

Just a comment typo: "number of contained objecct handles" - should be "object".

Ah, thanks!

chuck changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.Apr 11 2021, 2:31 PM
Closed by commit rG0c6282e842b3: bhyve: add SMBIOS Baseboard Information (authored by chuck). · Explain WhyApr 12 2021, 3:13 PM
This revision was automatically updated to reflect the committed changes.
chuck added a commit: rG0c6282e842b3: bhyve: add SMBIOS Baseboard Information.
jhb added a subscriber: lwhsu.Apr 12 2021, 5:58 PM

FYI, the repository is wrong because of the .arcconfig in and that 'rS' still references the old svn repository. @lwhsu was going to look at either renaming the rS alias to the git repository, or adding a new alias that could be used in .arcconfig to fix this.

chuck added a comment.Apr 12 2021, 6:02 PM
In D29657#666751, @jhb wrote:

FYI, the repository is wrong because of the .arcconfig in and that 'rS' still references the old svn repository. @lwhsu was going to look at either renaming the rS alias to the git repository, or adding a new alias that could be used in .arcconfig to fix this.

The work was done via git, but I used git-arc for the first time to submit the review. I poked through the script, but didn't find anything that obviously set the repository.

jhb added a comment.Apr 12 2021, 7:37 PM

The repository is set implicitly via the .arcconfig file. All my reviews are wrong as well until such time as either .arcconfig or the phab config is changed.

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
49 lines

Diff 87315

View Options

usr.sbin/bhyve/smbiostbl.c

Loading...