ipmi: support getting address from EFI
ClosedPublic
Actions

Authored by yinlong.lu_dell.com on Apr 27 2021, 6:23 AM.

Details

Reviewers

dab
vangyzen

Commits

rGa7b187860cb7: ipmi: support getting address from EFI
rGee8b757a949a: ipmi: support getting address from EFI

Summary

The original implementation only support get address from legacy BIOS (search the SMBIOS_SIG pattern in fix address space).

This new patch would try to get the SMBIOS table from EFI through efirt (EFI Runtime Services) firstly and would continuous search in the legacy BIOS if NULL address returned from EFI.

By this way the ipmi function could support both legacy BIOS and UEFI system.

This solution is also based on the following commits.
https://reviews.freebsd.org/D29270
ipmi,smbios: move smbios_walk_table to smbios.h

https://reviews.freebsd.org/D29276
smbios: support getting address from EFI

Test Plan

Use dmidecode to get the SMBIOS entry address in both legacy BIOS and EFI system and compare this address with the one return in efi_get_table or bios_sigsearch in the ipmi_smbios_probe.

Test with UEFI:
root@Freebsd:~ # dmidecode | less

dmidecode 3.3
SMBIOS entry point at 0x0ff74000

The address returned in ipmi_smbios_probe by efi_get_table is also 0xff74000 which means we got the correct address from efirt.

Test with legacy BIOS:
The address return by efi_get_table is 0 and returned by bios_sigsearch is 0xf69b0 which is same address as before.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

yinlong.lu_dell.com requested review of this revision.Apr 27 2021, 6:23 AM

yinlong.lu_dell.com created this revision.

Looks good; just a few style nits.

sys/dev/ipmi/ipmi_smbios.c
155	style(9) discourages initialization of variables in their declaration, so the initialization here should be dropped and moved to inside the condition compilation block at line 164: struct uuid efi_smbios;
160	style(9) discourages initialization of variables in their declaration, so this would be preferred: u_int32_t addr; addr = 0;
164	Initialize `efi_smbios` here: efi_smbios = EFI_TABLE_SMBIOS;