Paths

Table of Contentst

ipmi,smbios: move smbios_walk_table to smbios.h
ClosedPublic
Actions

Authored by val_packett.cool on Mar 15 2021, 5:55 PM.

Details

Reviewers

allanjude
rpokala
dab
vangyzen

Group Reviewers

Contributor Reviews (src)

Commits

rG0ea19e39ff05: ipmi,smbios: move smbios_walk_table to smbios.h
rGf689cb23b278: ipmi,smbios: move smbios_walk_table to smbios.h

Summary

This function will be used for exposing DMI info as sysctls in the smbios module (in an upcoming review).

While here, add __packed to the structs.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

val_packett.cool requested review of this revision.Mar 15 2021, 5:55 PM

val_packett.cool created this revision.

val_packett.cool added reviewers: allanjude, rpokala.Mar 15 2021, 8:55 PM

This function will be used for exposing DMI info as sysctls in the smbios module (in an upcoming review).

Yay! \o/

This has been on my to-do list for years, but E_NO_TIME.

val_packett.cool added a child revision: D29277: smbios: expose useful DMI information as sysctl and dmesg.Mar 15 2021, 9:16 PM

LGTM

This revision is now accepted and ready to land.Mar 31 2021, 1:59 PM

vangyzen accepted this revision.Mar 31 2021, 3:30 PM

Closed by commit rGf689cb23b278: ipmi,smbios: move smbios_walk_table to smbios.h (authored by val_packett.cool, committed by vangyzen). · Explain WhyApr 7 2021, 8:09 PM

This revision was automatically updated to reflect the committed changes.

vangyzen added a commit: rGf689cb23b278: ipmi,smbios: move smbios_walk_table to smbios.h.

yinlong.lu_dell.com mentioned this in D30007: ipmi: support getting address from EFI.Apr 27 2021, 6:23 AM

vangyzen added a commit: rG0ea19e39ff05: ipmi,smbios: move smbios_walk_table to smbios.h.Mar 3 2022, 2:22 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 3 2022, 2:22 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

ipmi/

ipmi_smbios.c

29 lines

smbios/

smbios.h

31 lines

Diff 86975

View Options

sys/dev/ipmi/ipmi_smbios.c