misc/mbuffer: Update to 20210328
ClosedPublic
Actions

Authored by loader on May 18 2021, 5:57 PM.

Details

Reviewers

Commits

R11:4e5069c63b55: misc/mbuffer: Update to 20210328

Summary

misc/mbuffer: Update to 20210328

- Update to 20210328
- Switch to USES=autoreconf gmake instead of patching configure and Makefile.in
- Take maintainership

Reviewed_by:	koobs
Approved by:	koobs (ports, mentor, implicit)
Differential_Revision: D30338
MFH:		No (feature release)

Test Plan

portlint: OK (looks fine.)
testport: OK (poudriere: 140006, [armv7,aarch64,i386,amd64], tested)

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

loader created this revision.May 18 2021, 5:57 PM

Herald added a subscriber: mat. · View Herald TranscriptMay 18 2021, 5:57 PM

loader requested review of this revision.May 18 2021, 5:57 PM

Harbormaster completed remote builds in B39277: Diff 89440.May 18 2021, 5:57 PM

loader retitled this revision from Proposed commit log message: ``` misc/mbuffer: Update to 20210328 to misc/mbuffer: Update to 20210328.May 18 2021, 6:00 PM

loader edited the summary of this revision. (Show Details)

I've tweaked the commit log message. This change also comes under implicit

This revision is now accepted and ready to land.May 19 2021, 1:55 AM

Thanks, @koobs.

Closed by commit R11:4e5069c63b55: misc/mbuffer: Update to 20210328 (authored by loader). · Explain WhyMay 19 2021, 10:04 AM

This revision was automatically updated to reflect the committed changes.

loader added a commit: R11:4e5069c63b55: misc/mbuffer: Update to 20210328.

One other note. When taking maintainer'ship or when combining multiple changes, land all changes that can be MFH'd first , and the version update separately.

This ensures ports in all branches have the same maintainer

In D30338#681556, @koobs wrote:

One other note. When taking maintainer'ship or when combining multiple changes, land all changes that can be MFH'd first , and the version update separately.

This ensures ports in all branches have the same maintainer

one commit to update the MAINTAINER and bump up PORTREVISION, and MFH this commit.
then another commit for the version update and no MFH, right?

Yep, rule of thumb:

Mergeable commits first
Non mergeable commits last

Mergeable commits:

Consistent metadata (maintainer, etc)
Bugfixes

In D30338#681798, @koobs wrote:

Yep, rule of thumb:

Mergeable commits first

Non mergeable commits last

Mergeable commits:

Consistent metadata (maintainer, etc)

Bugfixes