Page MenuHomeFreeBSD
Differential D30498

Fix syscall kld example
ClosedPublic
Actions

Authored by fernape on May 27 2021, 12:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 15, 9:52 AM
Unknown Object (File)
Fri, Nov 15, 9:38 AM
Unknown Object (File)
Wed, Nov 13, 1:56 AM
Unknown Object (File)
Mon, Nov 11, 3:47 PM
Unknown Object (File)
Sun, Nov 10, 4:43 PM
Unknown Object (File)
Sat, Nov 9, 6:50 AM
Unknown Object (File)
Fri, Nov 8, 6:22 PM
Unknown Object (File)
Fri, Nov 8, 6:05 AM
View All 54 Files
Subscribers
imp
jilles

Details

Reviewers
0mp
gbe
jilles
imp
Commits
rGdc318a4ffabc: Fix syscall kld example
Summary

PR: 255936

The syscall kld example does not build.

Test Plan
  • Apply patch
  • make
  • dmesg | grep syscall should show something like syscall loaded at 210

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

fernape created this revision.May 27 2021, 12:20 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 27 2021, 12:20 PM
Harbormaster completed remote builds in B39500: Diff 89990.May 27 2021, 12:20 PM
fernape requested review of this revision.May 27 2021, 12:20 PM
gbe added a reviewer: jilles.May 29 2021, 4:19 PM
gbe added a subscriber: jilles.

Should be fine, but since it is a src change I added @jilles for src review and approval.

imp accepted this revision.May 29 2021, 5:57 PM
This revision is now accepted and ready to land.May 29 2021, 5:57 PM
jilles added inline comments.May 29 2021, 7:00 PM
share/examples/kld/syscall/module/syscall.c
54–56

The comments are now redundant.

fernape updated this revision to Diff 90129.May 30 2021, 4:16 PM
  • Remove redundante comments (spotted by jills@)
This revision now requires review to proceed.May 30 2021, 4:16 PM
Harbormaster completed remote builds in B39571: Diff 90129.May 30 2021, 4:16 PM
fernape marked an inline comment as done.May 30 2021, 4:17 PM

Thanks!

As this is a small fix to the EXAMPLE, is it necessary to bump .Dd at commit time?

jilles accepted this revision.May 30 2021, 7:34 PM
In D30498#686136, @fernape wrote:

As this is a small fix to the EXAMPLE, is it necessary to bump .Dd at commit time?

This is not a man page and it does not have a .Dd.

This revision is now accepted and ready to land.May 30 2021, 7:34 PM
fernape added a comment.May 30 2021, 8:12 PM
In D30498#686206, @jilles wrote:
In D30498#686136, @fernape wrote:

As this is a small fix to the EXAMPLE, is it necessary to bump .Dd at commit time?

This is not a man page and it does not have a .Dd.

Oops! Sorry, the original PR mentioned SYSCALL_MODULE(9) man page, but there is only the path to the example not the code itself.

Closed by commit rGdc318a4ffabc: Fix syscall kld example (authored by fernape). · Explain WhyJun 9 2021, 10:31 AM
This revision was automatically updated to reflect the committed changes.
fernape added a commit: rGdc318a4ffabc: Fix syscall kld example.
fernape added a comment.Jun 9 2021, 10:32 AM

Thank you all for the review.

Revision Contents
Changeset List

PathSize
share/
examples/
kld/
syscall/
module/
4 lines

Diff 90624

View Options

share/examples/kld/syscall/module/syscall.c

Loading...