Differential D30963

riscv: Implement non-stub __vdso_gettc and __vdso_gettimekeep
ClosedPublic
Actions

Authored by jrtc27 on Jun 30 2021, 3:08 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 29, 11:02 AM

	Unknown Object (File)
	Wed, Nov 27, 3:39 AM

	Unknown Object (File)
	Thu, Nov 21, 3:08 AM

	Unknown Object (File)
	Wed, Nov 20, 11:47 PM

	Unknown Object (File)
	Wed, Nov 20, 8:30 PM

	Unknown Object (File)
	Sat, Nov 9, 8:29 AM

	Unknown Object (File)
	Sat, Nov 9, 7:08 AM

	Unknown Object (File)
	Sat, Nov 9, 4:46 AM

View All 31 Files

Subscribers

Details

Reviewers

arichardson
mhorne

Group Reviewers

Commits

rGc69a739379be: riscv: Implement non-stub __vdso_gettc and __vdso_gettimekeep
rG348c41d1815d: riscv: Implement non-stub __vdso_gettc and __vdso_gettimekeep

Summary

PR: 256905
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jrtc27 created this revision.Jun 30 2021, 3:08 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 30 2021, 3:08 PM

jrtc27 requested review of this revision.Jun 30 2021, 3:08 PM

Harbormaster completed remote builds in B40188: Diff 91572.Jun 30 2021, 3:08 PM

jrtc27 added inline comments.Jun 30 2021, 3:12 PM

lib/libc/riscv/sys/__vdso_gettc.c
48	Hm, plain csr_read might be more appropriate given the result is put in a u_int, though it's a bit academic given we don't support RV32. The two are the same on RV64 but on RV32 it'll loop until it reads a consistent time and timeh to get a 64-bit value from two 32-bit CSRs and then throw away the upper half.

Use csr_read in place of csr_read64

Harbormaster completed remote builds in B40190: Diff 91574.Jun 30 2021, 3:14 PM

Enable SV_TIMEKEEP

Harbormaster completed remote builds in B40193: Diff 91577.Jun 30 2021, 4:31 PM

Thanks! I can confirm that truss no longer shows the clock_gettime() syscalls with this version of the patch.

This revision is now accepted and ready to land.Jun 30 2021, 4:35 PM

Thanks for this one.

lib/libc/riscv/sys/__vdso_gettc.c
28	Nit: not required for new files

imp added inline comments.Jun 30 2021, 6:16 PM

lib/libc/riscv/sys/__vdso_gettc.c
28	for new files that won't be MFC'd to stable/12..... I don't think this will be, given the riscv support in 12 isn't so good (IIRC, I might be wrong), but thought I'd mention in case I am wrong.

mhorne added inline comments.Jun 30 2021, 6:22 PM

lib/libc/riscv/sys/__vdso_gettc.c
28	That's right, there's no point bringing this past stable/13, but the precision is helpful.

Closed by commit rG348c41d1815d: riscv: Implement non-stub __vdso_gettc and __vdso_gettimekeep (authored by jrtc27). · Explain WhyJul 5 2021, 3:18 PM

This revision was automatically updated to reflect the committed changes.

jrtc27 added a commit: rG348c41d1815d: riscv: Implement non-stub __vdso_gettc and __vdso_gettimekeep.

jrtc27 added a commit: rGc69a739379be: riscv: Implement non-stub __vdso_gettc and __vdso_gettimekeep.Sep 7 2021, 12:09 PM

Revision Contents
Changeset List

Path

Size

lib/

libc/

riscv/

sys/

2 lines

56 lines

sys/

riscv/

include/

2 lines

riscv/

4 lines

14 lines

Diff 91806

lib/libc/riscv/sys/Makefile.inc

Loading...

lib/libc/riscv/sys/__vdso_gettc.c

Loading...

sys/riscv/include/vdso.h

Loading...

sys/riscv/riscv/elf_machdep.c

Loading...

sys/riscv/riscv/timer.c

Loading...